Skip to content

Test blocked checkout retries and custom overlay slots in Chromium - #917

Open
markmur wants to merge 16 commits into
mainfrom
mm-web-blocked-overlay-browser-tests
Open

markmur wants to merge 16 commits into
mainfrom
mm-web-blocked-overlay-browser-tests

Conversation

@markmur

@markmur markmur commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Exercise repeated blocked attempts followed by a successful popup, checking that retries do not emit a premature close event. Also cover merchants replacing both overlay slots and retrying from their custom content.

The browser fixture records blocked alongside the existing lifecycle events so these sequences can be asserted. This coverage depends on the public event added in #835 and is separate from the bundle refactor in #916.

Stack

@markmur
markmur requested a review from a team as a code owner October 6, 2026 11:31
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 97%
95.41% (416/436) 84.33% (210/249) 97.34% (110/113)

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Bundle Size Budgets

Budget Size Limits Result
Web JavaScript (uncompressed) 35.37 KiB (0 B) 35 KiB soft / 50 KiB hard ➖ Above budget; no increase

Bundle and package size

Web bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.

Platform Measurement Compression Base Head Delta
Web JavaScript bundle Uncompressed 35.4 KiB 35.4 KiB 0 B
Web JavaScript bundle gzip 10.6 KiB 10.6 KiB 0 B
Web npm package (.tgz) gzip 91.6 KiB 91.6 KiB 0 B
Web package files (uncompressed)

These are uncompressed file sizes; they do not sum to the compressed package size above.

File Base Head Delta
dist/index.js.map 254.6 KiB 254.6 KiB 0 B
dist/custom-elements.json 50.6 KiB 50.6 KiB 0 B
dist/index.d.ts 48.2 KiB 48.2 KiB 0 B
dist/index.js 35.4 KiB 35.4 KiB 0 B
README.md 21.1 KiB 21.1 KiB 0 B
package.json 3.6 KiB 3.6 KiB 0 B
LICENSE 1.1 KiB 1.1 KiB 0 B
How sizes are measured

Measured from the PR base SHA and PR head SHA. Web bundle rows sum shipped .js, .mjs, and .cjs files under dist/, excluding source maps and declarations. The gzip bundle size sums files compressed individually with gzip -n -9. npm package sizes are gzip-compressed .tgz archives; Android AAR sizes are ZIP archives. Package sizes are not final app binary sizes.

@markmur
markmur force-pushed the ks-web-blocked-popup-event branch from f4f93f4 to 643a806 Compare October 6, 2026 12:46
@kyle-schellen
kyle-schellen force-pushed the ks-web-blocked-popup-event branch 2 times, most recently from 8905b5c to f289ade Compare October 7, 2026 00:12
@markmur
markmur force-pushed the ks-web-blocked-popup-event branch from f289ade to 82205ed Compare October 7, 2026 09:13
@kyle-schellen
kyle-schellen force-pushed the ks-web-blocked-popup-event branch from 82205ed to 924b591 Compare October 7, 2026 14:14
Base automatically changed from ks-web-blocked-popup-event to main October 7, 2026 14:42

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants