Repository navigation
Update README - #258
Merged
Merged
Update README#258
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The commands may use an unintended working-directory config instead of the systemd service configuration.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates s3d setup instructions to rely on the config lookup behavior merged in s3d PR #284.
Changes:
- Removes
sh -cand working-directory changes from setup commands. - Simplifies the surrounding instructions.
| File | Description |
|---|---|
| README.md | Simplifies s3d registration and credential commands. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
peterjan
requested review from
ChrisSchinnerl,
alexfreska,
chris124567 and
n8mgr
September 30, 2026 14:18
peterjan
marked this pull request as ready for review
September 30, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've merged SiaFoundation/s3d#284 we can get rid of sh -c.
NOTE: this is BLOCKED and should not be merged until we tag a new s3d release.