Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a base rule and a correlation rule as separate inputs currently fails with
Rule 'example_base' not found in rule collection, even though converting the directory containing both files works. Each input is resolved before the other inputs have been added.This defers reference resolution until all files, directories and stdin have been loaded. It uses APIs already available in pySigma 1.3.0 and keeps errors for genuinely missing references.
The new tests cover names and UUIDs, both input orders, separate directories and stdin. All 16 affected cases fail before the fix; those cases and three error/source-location controls now pass. The 71 conversion, filter, list, filename-template and loader tests pass with both pySigma 1.3.0 and current 1.5.1 source on Windows/Python 3.12. Black 23.3.0 passes for both changed files.
Broader offline checks bring the total to 116 passing tests and one existing skip. Twelve dataset-dependent
check/analysis tests fail because networking is disabled, identically on the original and patched code. Nine online plugin tests and the hosted platform matrix were not run locally; this is not a full-suite pass.