[pull] master from dotansimha:master - #1152
Merged
Merged
Conversation
…ions (#4683) (#11009) Fixes the 10 errors `plugins/typescript/operations` hits once the root tsconfig enables `strict: true`, mostly by widening the shared types it calls into instead of adding defaults at each call site: - plugin-helpers: `ComplexPluginOutput.prepend`/`append` accept `null` items, since operations prepends `getExactUtilityType()` and `getIncrementalUtilityType()` (`string | null`). Core already skips falsy items, and `mergeOutputs` output stays the same (TS2322). - visitor-plugin-common: `DeclarationBlock.withComment` accepts `undefined` for `description?.value` callers (TS2345), `parseEnumValues`'s `mapOrStr` is optional to match its `{}` default (TS2322), `ImportSource.namespace` accepts `null` like `namespacedImportName` (TS2322), and `optimizeOperations`'s `includeFragments` is optional to match relay-operation-optimizer (TS2322). - operations: default the optional plugin `info` argument (TS2339), skip document files without a `document` (TS2345), and guard `d.name` (TS18048). Generated output is unchanged. The strict typecheck goes from 307 to 283 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VB2AkFW99jZT4EYQjhRzF4 eddeee888:oss:issue-fix Co-authored-by: Claude <noreply@anthropic.com>
… bumps (#11010) * Improve Dependabot handling of ranges and pnpm lockfile - Use `versioning-strategy: increase-if-necessary` for published packages, so ranges like `^1.7.3` stay as-is when the new version already satisfies them and no needless release is triggered. - Add a workflow that regenerates pnpm-lock.yaml on Dependabot PRs. Jobs that run from a workspace member directory (e.g. /dev-test/*, /examples/*) only update that package.json and leave the root lockfile stale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AYHoZNAb9DLJFDqYb9Pr6 * Use latest actions * Fix dependabot-lockfile checkout and pnpm setup - Check out the Dependabot branch (`github.head_ref`) instead of the PR merge commit, so the rebase and push don't carry master's commits onto it. - Skip pnpm/setup's built-in install: in CI it runs frozen and fails on the stale lockfile this workflow is meant to fix. - Pin both actions by SHA, like the other workflows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AYHoZNAb9DLJFDqYb9Pr6 * Update pnpm/setup to v3.0.0 v3 also installs Node from .nvmrc. The `install` and `version` inputs are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AYHoZNAb9DLJFDqYb9Pr6 --------- Co-authored-by: Claude <noreply@anthropic.com>
… (#11012) * [fragment-matcher] fix: satisfy strict mode in fragment-matcher (#4683) Fixes the 13 errors `plugins/other/fragment-matcher` hits once the root tsconfig enables `strict: true`, with types-only changes: - read the optional plugin `info` argument as `info?.outputFile` (TS18048, TS2345) - type the introspection result as `ExecutionResult<IntrospectionResultData>` and annotate `createPossibleTypesCollection`, so the filter/sort/reduce callbacks are no longer implicit `any` (TS7006) - type `typename` and `type` as `string | undefined`, since they are only assigned for `apolloClientVersion` 2 or 3 (TS2454) Generated output is unchanged. The strict typecheck goes from 283 to 270 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MzUSkE6kGAfWan8VDUSkNt eddeee888:oss:issue-fix * Update based on preferences --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )