fix: clear React Doctor Critical findings (46 → 100) - #146
Merged
Conversation
Install the React Doctor skill/CI hook and repair all confirmed diagnostics: pnpm supply-chain hardening, fetch/chroma safety, a11y labels, parent sync without effects, and related cleanup.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tints-dev | 4ba98c4 | Commit Preview URL Branch Preview URL |
Aug 11 2026, 04:25 PM |
|
React Doctor found 2 new issues in 2 files · 2 warnings · score 60 / 100 (Needs work) · 31 fixed · vs 2 warnings
Reviewed by React Doctor for commit |
SimeonGriggs
marked this pull request as ready for review
August 11, 2026 16:13
Keep both TODO sections and regenerate pnpm-lock.yaml from the auto-merged package.json (security bumps + react-doctor).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }, [palette, paletteState, updateGlobal]); | ||
| // Commit local palette changes and notify parent from the event path | ||
| // (not an effect) when name + value are valid. | ||
| const commitPalette = useCallback( |
There was a problem hiding this comment.
React Doctor · react-doctor/react-compiler-no-manual-memoization (warning)
React Compiler can cache this function automatically. Verify that removing useCallback preserves behavior before simplifying it.
Fix → Profile compiler-managed code and remove useMemo, useCallback, or memo only when the manual cache no longer carries behavioral or performance intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Installed React Doctor and repaired every confirmed diagnostic that was driving the Critical health score.
Baseline → after
Install
.agents/skills/react-doctorpnpmscriptdoctor.github/workflows/react-doctor.yml.husky/pre-commitpnpm-workspace.yamlsupply-chain hardening (minimumReleaseAge,trustPolicy,blockExoticSubdeps)Notable fixes
window.open(..., "noopener,noreferrer")response.okchecks,chroma.validguards,useMemodeps, parent sync withoutuseEffectPalettesplit into smaller componentsMerge note
Rebased/merged latest
mainafter #145. Conflicts were simple (TODO.mdkeep-both + regeneratedpnpm-lock.yaml).package.jsonauto-merged cleanly (security bumps + react-doctor).Verification
pnpm test— 18/18 ✅pnpm audit— no known vulnerabilitiespnpm exec react-doctor --scope full— 100 / Great