[2.1]: Bugs fixed on 3.0 that are still in 2.1 #9753

Description

These bugs were fixed for 3.0, and the 3.0 pull request says the same fault is in 2.1. Each one has been checked against v2.1.7 and the current release-2.1 (bdae2ecda), and none has a 2.1 pull request yet. Line numbers are from v2.1.7.

This is a list for backporting, not a bug report. Each item can be ticked off by its own [2.1] pull request.

Notifications

• Watchers are never told that a topic was removed. 3.0: [3.0] Tells members watching a topic when it is removed #9749 (open)
  RemoveTopic2() calls sendNotifications($topic, 'remove') (Sources/RemoveTopic.php:75) and then removeTopics(). sendNotifications() only queues a background task. removeTopics() deletes the topic's log_notify rows (:542), and that is where the task looks for watchers, so it finds none. Quick moderation's remove (Sources/MessageIndex.php:1163) has the same order.
• MOVED and MERGED redirection posts are announced like ordinary posts. 3.0: [3.0] Does not announce MOVED and MERGED redirection posts #9748 (open)
  Sources/MoveTopic.php:314 and Sources/SplitTopics.php:1450 call createPost() without send_notifications => false, which defaults to true (Sources/Subs-Post.php:1801). Board watchers are emailed "New Topic: MOVED: …", and watchers of a merged topic are told about a new reply.
• Members who get every reply are told the emails will stop. 3.0: [3.0] Only says the emails will stop when they will #9747 (merged)
  Sources/tasks/CreatePost-Notify.php:537 picks the _once template with !empty($frequency), which is also true for "every reply" (1). The board branch at :552 already checks == 2.
• The email for a reply to a member report is never sent. 3.0: [3.0] Sends the email for a reply to a member report #9742 (open)
  Sources/tasks/MemberReportReply-Notify.php:157 asks for the template reply_to_user_reports, but the template is called reply_to_member_report. The task fails there. In the same function:
  • :151 reads member_name, which ReportToMod.php:453 passes as user_name.
  • PROFILELINK (:153) has no ?.
  • REPORTLINK (:154) points at area=userreports, which does not exist.
• Unsubscribe links ask a logged-out member to log in. 3.0: [3.0] Lets unsubscribe links work for members who are not logged in #9734 (merged), faults 2 and 3; fault 1 is new in 3.0.
  • With guest access off, the gate in index.php:290 does not let notifytopic/notifyboard through.
  • The link carries topic=/board= (Sources/tasks/CreatePost-Notify.php:626), so loadBoard() sends the guest to the login form when the board is not visible to guests.

Moderation and reporting

• A long report comment fails with "Data too long for column 'comment'". 3.0: [3.0] Widens the report comment column to fit an entity encoded report #9616 (merged)
  log_reported_comments.comment is varchar(255) on both engines, but the stored comment is entity-encoded while the form limit counts decoded characters. A 2.1 fix needs an upgrade step as well as the install SQL. This was first reported on the community forum against 2.1.7.
• The posts to split off a topic are listed in no defined order on PostgreSQL. 3.0: [3.0] Lists the posts to split off a topic in a defined order #9714 (merged)
  Sources/SplitTopics.php:243 and :267 only add ORDER BY for members who view topics newest first. With LIMIT, a post can appear on two pages and be missing from another.

Statistics

• The topic starters list shows eleven entries, or leaves gaps. 3.0: [3.0] Lists ten topic starters in the statistics centre #9725 (merged)
  Sources/Stats.php:476 uses if ($i > 10), which keeps ranks 0 to 10. A starter with no member to name (a guest or a deleted member) keeps a rank but shows nothing.

Errors

• With error logging off, the third error in a request dies with "loop detected". 3.0: [3.0] Count the errors that are on the stack, not the errors that happened #9606 (open)
  log_error() increments $error_call (Sources/Errors.php:39), but returns at :56 when logging is off, so it never reaches the reset at :156. Related: [2.1] Improve error reporting when a loop is detected #7801.

Issues References (Fixes|Related|Closes)

Related: #9749, #9748, #9747, #9742, #9734, #9616, #9714, #9725, #9606, #7801