[albertlast]

Description

This adds the tooling that converts the default theme's templates to Plates, and the tooling that proves a conversion changed nothing on the page. Part 2 (#9728) is the conversion itself, and every file under Themes/default/templates/ in part 2 comes out of this converter. Nothing here changes the forum; it is all under .dev/.

This is stacked on #9712 (template snapshot tests), which the comparison depends on. Until that merges, this PR's diff includes #9712's commits. The two commits that belong to this PR are the last ones: SnapshotTestCase can save each page's HTML, and the converter itself.

Converting

.dev/convert-templates.sh --from <commit> --all --skip Stats

• .dev/plates/convert.php works on PHP tokens, not with regular expressions. It turns each template_*() function into its own Plates file, laid out so the file outputs exactly the same bytes as the function did.
• Calls between templates become $this->subTemplate('name', [...]), with parameter names taken from the called function's signature. A converted template can therefore call a sub-template of either kind.
• It stops on anything it can't convert faithfully. It warns about anything a person should check: a template that returns a value, a parameter passed by reference, or a call whose parameters it can't find.
• The script starts from the old files as a given commit has them, so it can be repeated as often as needed with the same result.
• After converting, it applies three fix-ups the default theme needs, drops the empty lines the conversion leaves where HTML doesn't need them, and runs php-cs-fixer.

Checking

.dev/capture-pages.sh before
# change the templates
.dev/capture-pages.sh after
.dev/compare-pages.sh before after [--rendered] -v

• capture-pages.sh saves the HTML of all 232 pages the snapshot suite renders, on both engines. It also saves ssi_examples.php, some XML responses, and a probe that calls the template helpers directly, as a mod would.
• compare-pages.sh first masks what changes between any two runs: sessions, tokens, times and counts. By default, everything else must match byte for byte.
• With --rendered, runs of whitespace count as one space, as a browser shows them. Inside <pre>, <textarea> and <script>, where a newline matters, the bytes must still match exactly.

The snapshot suite in #9712 compares a description of each page's DOM, which ignores whitespace, attribute order and the forum's own data. That is right for catching a broken page, but too coarse to prove a conversion changed nothing. This byte-level check is what makes it reasonable to review a conversion of 54 templates by reviewing the converter rather than 342 generated files.

Verified

• On a clean checkout, .dev/convert-templates.sh --from ea5ae213e --all --skip Stats reproduces every file part 2 has under Themes/default/templates/. Stats is the exception: it was converted by hand, as the first test of the engine, before the converter existed.
• The capture and comparison were run on both engines. Straight out of the converter, 460 of the 464 pages were byte-identical to the old templates. The other four were the theme copy page, which part 2 changes on purpose, and ties in PostgreSQL's ordering ([3.0] Lists the forum administrators in a defined order #9721, [3.0] Ranks ties in the stats top tens in a defined order #9722).
• Two things the comparison caught during the conversion:
  • Literal '<', '?xml' pieces that, joined together, would have opened a PHP tag in every XML response. No snapshot page is an XML response; the extra captures found it.
  • A first version of the tidying step that removed newlines inside <script>.

Issues References (Fixes|Related|Closes)

Related: #9712 (this PR's base); #9728 (part 2 of 2, the conversion to Plates).

🤖 Generated with Claude Code