Repository navigation
[2.1] Lists ten topic starters in the statistics centre - #9759
Merged
jdarwood007 merged 1 commit intoOct 17, 2026
Merged
jdarwood007 merged 1 commit into
jdarwood007 merged 1 commit into
Conversation
$i > 10 kept ranks 0 to 10, which is eleven, and a starter with no member to name (a guest or a deleted member) left its rank empty. The list now takes the members found, in rank order, and keeps the first ten. Backport of SimpleMachines#9725. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #9725.
The statistics centre counts the twenty members with the most topics, looks up their names, and places each by rank:
Two things go wrong:
$i > 10keeps ranks 0 to 10, which is eleven. Every other list on the page has ten.The two can cancel out: on a forum where one of the top eleven is a guest, the list shows ten. So fixing only the
>would leave a gap.It now takes the members that were found, in rank order, and keeps the first ten.
Testing
Checked on a freshly installed
release-2.1forum, on MySQL 8.4 and PostgreSQL 17, with twelve members holding two topics each:Nothing in
log_errors.Issues References (Fixes|Related|Closes)
Related: #9753, #9725
🤖 Generated with Claude Code