Repository navigation
[2.1] Log index, board and topic views again - #9778
Merged
Merged
Conversation
Moving the logging block below the maintenance/KickGuest chain in smf_main() meant requests with no action (BoardIndex, MessageIndex, Display) returned before writeLog() and trackStats() were reached. Members, guests and bots browsing the index, boards and topics were no longer shown in Who's Online, last-active was not updated for them, and hit stats were undercounted. Run the logging block after the maintenance and KickGuest checks, so kicked guests are still not logged, but before the default-action branch. Both earlier branches return on every path, so the `elseif (empty($_REQUEST['action']))` becomes a plain `if`. $no_stat_actions and the integrate_pre_log_stats hook stay where they were. Follow-up to SimpleMachines#9215. Reported at https://www.simplemachines.org/community/index.php?topic=595172.0 Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
@albertlast could you update |
Collaborator
|
you mean smf 3.0 right? |
Contributor
Author
|
yes
…On Sat, Oct 17, 2026 at 6:19 AM albertlast ***@***.***> wrote:
*albertlast* left a comment (SimpleMachines/SMF#9778)
<#9778 (comment)>
you mean smf 3.0 right?
—
Reply to this email directly, view it on GitHub
<#9778?email_source=notifications&email_token=AADJNNZXPJCJC36YZPLRJPT5UNWXRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRTGQZTMMRRGI3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6234362126>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNNYTLZ4VMKH5FHVI5BL5UNWXRAVCNFSNUABDKJSXA33TNF2G64TZHMZTENJXGQ3TKO2JONZXKZJ3GU4DSNJQG42TGMJTUF3AE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AADJNN227R2V44NJBGCJQ735UNWXRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRTGQZTMMRRGI3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AADJNN6M2NLEXNGVOIDM25T5UNWXRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRTGQZTMMRRGI3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
live627
pushed a commit
that referenced
this pull request
Oct 19, 2026
The pages with no action in their URL are the ones 2.1 stopped logging in #9778: Who's Online, last-active and the hit counter all missed them. 3.0 resolves them to BoardIndex, MessageIndex and Display before preflight() runs, so they log as any other action does. This pins that down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Contributor
Author
|
@sbulen want to take a look at this? |
Contributor
|
Thanks for looking into this. I hope to do some testing & review this week! |
Contributor
|
Code looks good. (Ooof...) I have been testing, & guest activity looks good. Users on the forum report it solved their issue as well. I have confirmed it plays nice with other recent log_online updates as well (#9125). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the logging block below the maintenance/KickGuest chain in smf_main() meant requests with no action (BoardIndex, MessageIndex, Display) returned before writeLog() and trackStats() were reached. Members, guests and bots browsing the index, boards and topics were no longer shown in Who's Online, last-active was not updated for them, and hit stats were undercounted.
Run the logging block after the maintenance and KickGuest checks, so kicked guests are still not logged, but before the default-action branch. Both earlier branches return on every path, so the
elseif (empty($_REQUEST['action']))becomes a plainif.$no_stat_actions and the integrate_pre_log_stats hook stay where they were.
Follow-up to #9215.
Reported at https://www.simplemachines.org/community/index.php?topic=595172.0