Skip to content

WIP Dispatch, WEnum API changes in new wayland-rs - #2017

Draft
ids1024 wants to merge 6 commits into
Smithay:masterfrom
ids1024:wayland-update
Draft

ids1024 wants to merge 6 commits into
Smithay:masterfrom
ids1024:wayland-update

Conversation

@ids1024

@ids1024 ids1024 commented Apr 29, 2026

Copy link
Copy Markdown
Member

Description

Based on #2008.

Beyond what that PR does, this also allows the availablility of Dispatch implementations to be inferred usually by just the *Handler trait for the protocol. Though it looks like Rust still can't infer bounds like <D as SeatHandler>::KeyboardFocus: WaylandFocus from placing them on the trait (eventually it should?).

Uses Smithay/wayland-rs#902.

Checklist

@ids1024
ids1024 force-pushed the wayland-update branch 2 times, most recently from b3948f7 to 1073bad Compare May 20, 2026 16:07
@ids1024 ids1024 changed the title WIP Dispatch API changes in new wayland-rs WIP Dispatch, WEnum API changes in new wayland-rs May 20, 2026
@ids1024
ids1024 force-pushed the wayland-update branch 2 times, most recently from 3bc5a9b to c7a5d6c Compare July 16, 2026 18:45
@ids1024
ids1024 force-pushed the wayland-update branch 2 times, most recently from 47d532a to da30de9 Compare September 17, 2026 21:30
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.97222% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.25%. Comparing base (22571ba) to head (b2524b0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/wayland/shell/wlr_layer/types.rs 0.00% 11 Missing ⚠️
...ayland/virtual_keyboard/virtual_keyboard_handle.rs 0.00% 9 Missing ⚠️
src/wayland/compositor/handlers.rs 0.00% 7 Missing ⚠️
src/wayland/dmabuf/mod.rs 0.00% 7 Missing ⚠️
src/wayland/text_input/text_input_handle.rs 0.00% 6 Missing ⚠️
src/backend/egl/display.rs 0.00% 5 Missing ⚠️
src/wayland/shm/handlers.rs 73.68% 5 Missing ⚠️
src/wayland/foreign_toplevel_list/mod.rs 0.00% 4 Missing ⚠️
src/wayland/shell/kde/decoration.rs 0.00% 4 Missing ⚠️
src/wayland/cursor_shape.rs 0.00% 3 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
- Coverage   17.39%   17.25%   -0.15%     
==========================================
  Files         187      187              
  Lines       30494    30417      -77     
==========================================
- Hits         5304     5248      -56     
+ Misses      25190    25169      -21     
Flag Coverage Δ
wlcs-buffer 15.00% <40.97%> (-0.15%) ⬇️
wlcs-core 14.57% <40.97%> (-0.16%) ⬇️
wlcs-output 6.39% <28.47%> (-0.25%) ⬇️
wlcs-pointer-input 16.21% <40.97%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Based on Smithay#2008.

Beyond what that PR does, this also allows the availablility of
`Dispatch` implementations to be inferred usually by just the `*Handler`
trait for the protocol. Though it looks like Rust still can't infer
bounds like `<D as SeatHandler>::KeyboardFocus: WaylandFocus` from
placing them on the trait (*eventually* it should?).

Uses Smithay/wayland-rs#902.

WIP Update for wayland-rs master (WEnum changes)

disable `backend_winit` for now

WIP

cargo fix

WIP update winit to version using new wayland-rs

Need to clean up pointer casts/unwraps

cast

dispatch

includes

available_since

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants