Repository navigation
fix: active window fixes - #2194
Merged
Merged
Conversation
Member
|
Can you rebase? 506fda0 should've fixed CI |
mayakwd
force-pushed
the
fix/xwm-clear-active-window
branch
from
October 6, 2026 14:03
953818e to
e7b6218
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up for the previous
_NET_ACTIVE_WINDOWclear PR.During thorough investigation of the issue regarding mouse-look lock in the games connected to Xwayland and Wine (Proton), I found out that the implementation is not quite aligned with X server behavior.
So what exactly X server does when focus move from a window to None or PointerRoot:
FocusOutwithNotifyDetail::NONLINEAR/INFERIOR(andNONLINEAR_VIRTUALto the ancestors), and never sendNotifyDetail::NONEto a non-root window.FocusInwithNotifyDetail::NONEorNotifyDetail::POINTER_ROOTto the root, meaning the clearing of the_NET_ACTIVE_WINDOWThe other focus-tracking issues I found and fixed:
POINTER_ROOT, the server sendsNotifyDetail::POINTERto the window under pointer, which is not an activation. ThusFocusInwithNotifyDetail::POINTERis now ignored.FocusInwithNotifyMode::GRAB/UNGRABis now ignored - keyboard grab redirects keys without changing the actual focus. Meaning that previous behavior did the following_NET_ACTIVE_WINDOWchanges: "app" -> "menu" -> "app".Checklist