Prepare 5.0 release - #296
Merged
Merged
Conversation
… test - Add Pester unit tests for all previously-untested public functions - Fix New-ServiceNowChangeTask assigned_to/AssignedTo bug - Fix New-ServiceNowCartItem mandatory-variable detection for display-value style objects returned by some instances - Fix Unit.GenericModule.Tests.ps1 Pester Discovery/Run scoping bugs (BeforeAll, -ForEach instead of hand-rolled foreach, and full FunctionsToExport parsing via Import-PowerShellDataFile instead of fragile line-based regex) - Add Tests/Invoke-ServiceNowLiveSmokeTest.ps1 for manual validation against a live instance, covering all 20 public functions; validated against dev409606 - Enable Pester in CI (ci.yml), excluding legacy tests that require live credentials - Update RELEASE.md with all changes since v4.1.0 and contributor credits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release-prep work for the next release (5.0), covering test coverage, a couple of real bug fixes found along the way, CI improvements, and updated release notes.
Testing
Unit.GenericModule.Tests.ps1- it had two Pester v5 Discovery/Run-phase scoping bugs that caused manifest property checks to silently fail/under-test (only 2 of 20 exported functions were actually being verified). All 20 functions are now genuinely covered.ci.yml) - it was previously commented out and pointed at a stale test path. Now runs the modern per-function test suite, excluding legacy tests that require live credentials and can't run non-interactively.Tests/Invoke-ServiceNowLiveSmokeTest.ps1, a manually-run script that exercises all 20 public functions against a real ServiceNow instance, with self-cleanup. Validated end-to-end (20/20 pass) against a live dev instance.Bug fixes found via testing
New-ServiceNowChangeTask: fixedAssignedTo/assigned_tofield name mismatch.New-ServiceNowCartItem: fixed mandatory-variable detection to handle instances that return themandatoryflag as a display-value-style object instead of a plain boolean/string.Release notes
RELEASE.mdwith all changes since v4.1.0, crediting external contributors (@jmunroBT, @CATgwalker, @TriggerAu) for their PRs.Notes
ModuleVersionin the manifest is left as-is (5.0); the CD workflow auto-increments the patch/build number on publish.CHANGELOG.mdis intentionally untouched - the CD automation mergesRELEASE.mdinto it.