Refine rewards tier upgrade and top-up flows - #2564
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
qa reverted the tier-upgrade feature in the 18 reverts merged with #2561. This branch builds on that feature, so a plain merge would delete the code it changes and leave it importing modules that no longer exist. This merge brings in everything else qa has gained since the branch point (the deposit rework, the 0.03% fee notice, issuer-based deposit routing) and keeps the feature: every path the reverts removed is back in its pre-revert state, with this branch's refinements on top. Built as qa, plus the exact inverse of the reverts (a1e3912..03c17c2), plus this branch. qa's post-revert changes apply unchanged over the restored feature. The only file both touch is constants/modals.ts, where TIER_UPGRADE_MODAL returns beside qa's removal of OPEN_DEPOSIT_CHAIN. store/useDepositStore.ts takes qa's changes and this branch's upgradeTopUp slice together. Merging this PR therefore brings the tier-upgrade feature back to qa. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6iamcwoqjwq77x9kDCPzR
qa now opens "Select token" first from Crypto and has deleted the "Select chain" step (a1e3912, 6ee35e0), so DEPOSIT_MODAL.OPEN_DEPOSIT_CHAIN no longer exists. The chooser test asserted that an ordinary Crypto press opens it, which failed once qa was merged. The soFUSE top-up test's negative check against it passed vacuously, since it compared against undefined. Both now name the step Crypto opens on a phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6iamcwoqjwq77x9kDCPzR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
no-consolewarning instore/swapStore.ts.git diff --checkpassed.tsc --noEmitreports 10 errors in files outside this change.Integration note
This branch started at
qacommit16d0fb29. Since then,qaadvanced and reverted the tier-upgrade feature on which these changes depend. The branch is intentionally left at its original base; merging it into currentqahas conflicts in rewards components and the deposit store. Review the feature's return before resolving those conflicts. This PR is a draft until that decision and integration are complete.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.