fix(deposit): mint the address for Wirex cardholders only - #2572
Merged
Merged
Conversation
The stablecoin rule was applied to everyone. It is a Wirex rule: the address is minted against the card destination and the backend resolves that by issuer, so for a Wirex cardholder it delivers to their Safe on Fuse — the balance their card settles from — while for a Rain cardholder it would deliver to the card, and for someone with no card there is no issuer to resolve at all. Everyone but Wirex now sees the Safe address for every currency, as they did before. This also closes the gap noted when that change went in. The savings flow's "Deposit from an external wallet" route reaches this screen without checking the issuer, so a Rain cardholder could get there — and with the rule applied to all, their stablecoins would have landed on their card instead of their wallet. The check now sits on the address itself rather than on the routes into it, so no entry point has to remember. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stablecoin rule was applied to everyone. It is a Wirex rule: the address is minted against the card destination and the backend resolves that by issuer, so for a Wirex cardholder it delivers to their Safe on Fuse — the balance their card settles from — while for a Rain cardholder it would deliver to the card, and for someone with no card there is no issuer to resolve at all. Everyone but Wirex now sees the Safe address for every currency, as they did before.
This also closes the gap noted when that change went in. The savings flow's "Deposit from an external wallet" route reaches this screen without checking the issuer, so a Rain cardholder could get there — and with the rule applied to all, their stablecoins would have landed on their card instead of their wallet. The check now sits on the address itself rather than on the routes into it, so no entry point has to remember.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.