Repository navigation
Settings: redesign Profile, Account details and Notifications - #2664
Merged
Merged
Conversation
Rebuilds Settings around the new Profile design: avatar with an editable colour, tier and verification chips, Rewards and Refer & earn tiles, and Account / Security & alerts / Support groups with live status (card spend mode, "Add 2FA", push on/off). Statements are left out of this release. Account details gains Username, Email and Identity verification rows, keeps the wallet address, and replaces the delete modal with a sheet that checks the balance is withdrawn and no card payments are pending, then asks for DELETE. The copy says deletion is immediate: the backend closes the account on the spot, so the design's 14-day window is behind DELETION_GRACE_PERIOD_DAYS until it exists. Adds a Notifications screen with the push-permission card. Per-category switches call /accounts/v1/users/notification-preferences and stay hidden while that endpoint 404s, since the backend has no preferences yet. The avatar colour is kept on the device per account; there is no avatar storage on the backend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Profile (
settings/index.tsx)kycStatusisapproved.referrerUsdfrom the referral summary).CARD_INFOfor cardholders and to activate or onboarding otherwise.DesktopSettingscomponent is removed. It was never rendered.Edit avatar sheet: eight colour swatches behind the initial. The choice is saved per account on the device (MMKV), because the backend has no avatar storage. The library and camera options are left out until there is somewhere to upload a photo.
Account details (
settings/account.tsx)user_…handles.totalAssets, card balance included). "Withdraw" opens All assets.pending.DELETE.Notifications (
settings/notifications.tsx, new route)GET/PATCH /accounts/v1/users/notification-preferences, with an optimistic update and rollback on failure. That endpoint does not exist yet. The switches stay hidden while it returns 404, so for now this screen shows the permission card and the email footnote.Things reviewers should know
DELETE /auths/delete-accountcloses the account immediately, and later sign-ins get a 403. The sheet therefore says deletion is immediate and permanent. SettingDELETION_GRACE_PERIOD_DAYSincomponents/Profile/deleteAccount.tsswitches to the 14-day copy once the backend supports it.push.service.ts. The open questions:marketingConsentfield.delete-accountonly deletes card rows in our database. It doesn't cancel the card with Rain or Wirex.CardBottomSheet: Gorhom on native, a dialog on web, and a modal on desktop.Testing
tsc: no new errors. The 9 errors it reports already exist onqa.deleteAccount.test.ts) and the avatar helpers (avatarColors.test.ts). The existing Security tests still pass. 25 tests pass in total.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.