Repository navigation
feat(deposit): offer EURC on Base on the wallet deposit screen for Wirex - #2668
Merged
Merged
Conversation
The EURC row only existed in "Fund your card"; the wallet "Add funds -> Select token" screen builds its list from BRIDGE_TOKENS, which EURC is kept out of. - Wirex cardholders now see EURC after USDC/USDT, on Base only, through the minted card deposit address, which the backend delivers to the Safe on Base. - Everyone else's list is unchanged: the helpers take a withEurc flag that defaults off. - Fee notice: Wirex wallet EURC is free on Base, charged elsewhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#2667 added EURC to "Fund your card" only. The wallet Add funds → Select token screen builds its list from
BRIDGE_TOKENS, which EURC is deliberately kept out of, so Wirex cardholders didn't see it there.Wirex cardholders now get EURC in "Select token", after USDC and USDT:
EURC_TOKENS, which lists only Base.usesDirectDepositAddress. The backend (Solid-Money/solid-backend#1947, merged) delivers it as EURC to the Safe on Base. Because the address is minted, the screen scans for the deposit and the deposit shows up in activity.Nobody else's list changes. Rain cardholders and users with no card don't see EURC.
Changes
WalletDepositAddress/constants.ts:offersWalletDepositEurc(provider)returns true for Wirex only.withEurcflag that defaults off.DIRECT_DEPOSIT_SYMBOLS, the display order and the icon fallbacks.WalletDepositTokens,WalletDepositNetworkListand the address screen passwithEurcbased on the card provider.depositFee.ts: Wirex wallet EURC is free on Base and charged elsewhere. That's only Base today, so no fee notice shows.Tests
Ran each of these individually; all pass:
WalletDepositAddress/__tests__/walletDepositConstants.test.ts(35): new EURC cases (Wirex-only, Base-only, display order, chain resolution, icon)lib/utils/__tests__/depositFee.test.ts(43)tscshows no new errors; the 10 existing errors are the same on master.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.