Repository navigation
fix(layout): stop the Home crash from the push-reminder gate - #2671
Merged
Merged
Conversation
…e crash The push-reminder gate added in #2669 read `state.modal`, which does not exist on DepositState, so `depositModal` was always undefined. Once a signed-in user reached a settled Home screen, `depositModal.name` threw and the error boundary replaced the page on web and native. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #2669 shipped, signed-in users see "Oops, something went wrong" on Home (web and native via the OTA update).
The push-reminder gate in
app/(protected)/_layout.tsxreadsuseDepositStore(state => state.modal), butDepositStatehas nomodalfield (it iscurrentModal).depositModalis therefore alwaysundefined, and once the user is on a settled Home screen with nothing else open,depositModal.namethrowsTypeError: Cannot read properties of undefined (reading 'name'). The throw happens in the layout itself, before the hook's web check, so web crashes too.Fix
Read
state.currentModal.Verification
npx tsc --noEmiton master reportsTS2339: Property 'modal' does not exist on type 'DepositState'at_layout.tsx:70; with this change that error is gone. The 8 remaining errors are pre-existing and in unrelated files.tsc --noEmitstep in.github/workflows/lint.ymlis commented out.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.