Repository navigation
fix(card): label the Base EURC card "euro spending", not "lending" - #2677
Merged
Merged
Conversation
The enable card read "Enable euro lending", but nothing is lent: EURC on the Base instance is spendable and not collateral, and lending is not planned. Rename the title and accessibility label to "Enable euro spending" and drop the doc comments that defended the old wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The card that turns on EURC spending on Base said "Enable euro lending". It now says "Enable euro spending" (title and accessibility label).
Why
Nothing is lent. On the Base instance EURC is
spendable: true, collateral: false, so enabling it lets the card spend a euro balance, and nothing more. Lending against EURC isn't planned, so "lending" misdescribes the feature.Also
Rewrote the doc comments in
EnableEuroSpendCard.tsxanduseEuroSpendEnablement.tsthat had defended the "lending" wording. No behaviour change: the gating, the enable transaction and the tracking events are unchanged, and the events already said "spend".🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.