Repository navigation
fix(card): let Hong Kong users declare their country, and ask before Didit - #2678
Merged
Merged
Conversation
handleProceedToKyc required a user-picked country only on the Sumsub branch. An IP in a Rain-only market routed straight to Didit with nobody asked: a Hong Kong resident whose IP resolved to Singapore got a Rain card customer that nothing rewrites, in a Didit questionnaire that does not offer Hong Kong. The backend refuses a Didit card session only for a country Wirex serves, and an SG IP gave it nothing to refuse on. The declared-country check now runs for both providers. The home setup step reaches this action with no gate having run, so this is where it has to live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
COUNTRIES listed UN member states only, so nine markets we issue cards in could not be picked: Hong Kong, Macao, Gibraltar, Guernsey, Isle of Man and Jersey (Wirex), and Cayman Islands, Turks and Caicos and Ivory Coast (Rain). Hong Kong users picked China, were told the card is unavailable, and some then picked an unrelated country to get through. The other two readers (VA apply modal, card reveal) only look up a name by code, so adding entries is safe for them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hong Kong users reported they couldn't select Hong Kong and were stuck on Didit (Rain). Server routing was already right: HK is on the
wirexcard list, so it routes to Sumsub. The problem was in the app:constants/countries.tslisted UN member states only. Users picked China, were told the card is unavailable, and some then picked an unrelated country (one chose Austria) to get through.handleProceedToKycrequired a country the user picked only on the Sumsub branch. A Hong Kong resident whose IP resolved to Singapore went straight to Didit and got a Rain card record that nothing rewrites. The backend refuses a Didit card session only for a country Wirex serves, so a Singapore IP gave it nothing to refuse on.Changes
Notes
user.countryto HK and moving their card record to Wirex/Sumsub. chankw's phone has China saved, so they stay blocked until this ships.tscshows the same errors as master, none in these files. ESLint and Prettier pass. Tests not run.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.