Adjust scripts to match (pivot)#306
Draft
SharonStrats wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to run I received a few issues and wanted to update the scripts to avoid others having the same problems.
Pivot was apart of the watch-pivot script but wasn't added during reset (setup - which calls reset). Also there were repos added to the watch-pivot that are not added during setup. I removed them.
This is just a draft as I wasn't sure if we wanted to add in profile-pane and contacts-pane into the reset instead of removing them from the watch-pivot script?
Also solid-logic needs the types for rdflib in particular this file lib/index.d.ts. rdflib's build doesn't build the types, I could create a PR in rdflib to modify the build script. (maybe I should do that instead) but for now i just added a special step to run build:types for rdflib.
The intention behind this PR is that: I think someone should be able to clone the repo, run setup and watch-pivot and have everything work.