nightly-{dmg,linux}: split upstream Firefox version from release version - #148
Merged
Merged
Conversation
…ersion Root cause of PR #147's silent failure: env VERSION was conflated. It's used for workspace paths (build/workspaces/human-secure-VERSION-1/source), cache keys, and the upstream Firefox tarball URL — but I ALSO wired it to the Info.plist version + artifact filename. Passing version=150.0.6 made the workflow look for a workspace at build/…-150.0.6-1 that doesn't exist because Firefox source is pinned upstream at 150.0.1. Split into two envs: VERSION = pinned UPSTREAM Firefox tarball (150.0.1, immutable) BEARBROWSER_VERSION = what WE ship as (defaults to VERSION; override via workflow_dispatch input release_version) Release cut is now: gh workflow run nightly-dmg.yml --ref main -f release_version=150.0.6 gh workflow run nightly-linux.yml --ref main -f release_version=150.0.6 Workspace paths, cache, and Firefox source download all keep the pinned 150.0.1 they need. Packaging (--version arg) and artifact filenames use BEARBROWSER_VERSION. Nightly semantics preserved when no input passed.
mdheller
force-pushed
the
release-build/split-firefox-vs-release-version
branch
from
August 4, 2026 04:09
5cb4388 to
1dc394a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why (root cause from #147's silent failure)
#147 added `inputs.version` to both nightly workflows so a release cut could pass `version=150.0.6`. It didn't work: the DMG dispatch failed immediately in "Fetch Firefox source tarball" because it tried to `cd build/workspaces/human-secure-150.0.6-1/source` — a directory that doesn't exist because Firefox source is pinned upstream at 150.0.1.
The `VERSION` env is conflated. It's simultaneously:
Overriding it to 150.0.6 breaks the first meaning without helping the second.
Change
Split into two envs:
Only three call sites use `BEARBROWSER_VERSION`:
Everything else keeps the pinned upstream `VERSION`.
Release cut becomes
```
gh workflow run nightly-dmg.yml --ref main -f release_version=150.0.6
gh workflow run nightly-linux.yml --ref main -f release_version=150.0.6
```
Adversarial-review checklist
Test plan
Post-merge, dispatch both nightlies with `release_version=150.0.6` and:
Blast radius
Additive — no existing trigger path changes behaviour. Non-dispatch triggers (schedule, push) still ship the nightly `150.0.1` default.