Skip to content

promotion-gate: use plistlib for CFBundleShortVersionString #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdheller merged 1 commit into from
Aug 4, 2026
Merged

promotion-gate: use plistlib for CFBundleShortVersionString #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/workflows/promotion-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,24 +79,32 @@ jobs:
DMG=$(ls release-assets/*macos*.dmg 2>/dev/null | head -1)
[ -f "$DMG" ] || { echo "no macOS DMG in release; skipping plist gate"; exit 0; }
sudo apt-get update -qq
sudo apt-get install -y -qq p7zip-full libplist-utils
sudo apt-get install -y -qq p7zip-full
# Pick whichever 7-Zip CLI got installed.
SEVENZ=""
for cand in 7z 7zz 7za; do
if command -v "$cand" >/dev/null 2>&1; then SEVENZ="$cand"; break; fi
done
[ -n "$SEVENZ" ] || { echo "::error::no 7z-family binary found after installing p7zip-full"; exit 1; }
[ -n "$SEVENZ" ] || { echo "::error::no 7z-family binary found"; exit 1; }
echo "using 7z CLI: $SEVENZ"
mkdir -p release-assets/dmg-extract
"$SEVENZ" x -o./release-assets/dmg-extract -y "$DMG" > /dev/null
PLIST=$(find release-assets/dmg-extract -name Info.plist -path "*BearBrowser.app/Contents/*" | head -1)
[ -f "$PLIST" ] || { echo "::error::no Info.plist in DMG"; find release-assets/dmg-extract -maxdepth 4 -type d | head -20; exit 1; }
# Convert to XML if binary (plistutil handles both formats).
plistutil -i "$PLIST" -o /tmp/plist.xml 2>/dev/null || cp "$PLIST" /tmp/plist.xml
VERSION=$(grep -A1 CFBundleShortVersionString /tmp/plist.xml | tail -1 | sed -E 's,.*<string>(.*)</string>.*,\1,')
# Read the plist with Python's plistlib — handles BOTH binary and XML
# formats, always available. Prior attempt piped grep|sed against
# plistutil output; plistutil silently failed (its `2>/dev/null`
# swallowed the error) and grep matched the binary blob but sed
# extracted nothing. Second promotion-gate false-negative in a row.
VERSION=$(python3 -c "
import plistlib, sys
with open(sys.argv[1], 'rb') as f: d = plistlib.load(f)
print(d.get('CFBundleShortVersionString',''))
" "$PLIST")
EXPECTED="${TAG#v}"
echo "plist CFBundleShortVersionString: $VERSION"
echo "release tag (without leading v): $EXPECTED"
echo "plist CFBundleShortVersionString: '$VERSION'"
echo "release tag (without leading v): '$EXPECTED'"
[ -n "$VERSION" ] || { echo "::error::plistlib returned empty version"; exit 1; }
[ "$VERSION" = "$EXPECTED" ] || { echo "::error::plist version $VERSION != tag $EXPECTED"; exit 1; }

- name: Update-check network hygiene smoke
Expand Down
Loading