Ensure GetFileSystemProperties is called only on ONLINE volumes. - #107
Merged
Conversation
zleyyij
reviewed
Aug 10, 2026
| { | ||
| //COM HResults | ||
| public const uint HR_PROPERTIES_INCOMPLETE = 0x00042715u; | ||
| public const uint VDS_E_NO_MEDIA = 0x80042412u; |
Member
There was a problem hiding this comment.
This constant is introduced, but I don't see anywhere where it's used.
Contributor
Author
There was a problem hiding this comment.
Removed in new commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check to make sure getting file system information function is ran only on online volumes. The function will fail if ran on offline volumes or empty media on removable devices like flash card adapters.