Add antialiased decimation and allow non-integer resampling rates#4621
Open
grahamfindlay wants to merge 1 commit into
Open
Add antialiased decimation and allow non-integer resampling rates#4621grahamfindlay wants to merge 1 commit into
grahamfindlay wants to merge 1 commit into
Conversation
Adds antialised decimation to both `DecimateRecording` and `ResampleRecording`. Opt-in for `DecimateRecording` with the `antialias` parameter. For `ResampleRecording`, antialiasing is always applied.
grahamfindlay
added a commit
to grahamfindlay/spikeinterface
that referenced
this pull request
Jun 17, 2026
Resolved resample.py by hand: kept dev's gap-handling (gap_tolerance_ms, section-wise resampling) and layered the feature's balanced multipass anti-aliased decimation on top. The non-gapped integer path uses get_antialiased_decimated_traces (exact margins); the gapped section path now cascades the same balanced sub-13 factors; non-integer rates relaxed; q>13 warning narrowed to unsplittable primes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #4605 : Adds antialised decimation (multipass with balanced factors, when possible) to both
DecimateRecordingandResampleRecording. Opt-in forDecimateRecordingwith theantialiasparameter (preserves existing default behavior). ForResampleRecording, antialiasing is always applied. For a future release where existing default behavior can be changed, I would recommend makingantalias=Truethe default.For simplicity, we could just remove the fast decimation path from
ResampleRecordingentirely and instead, if an integer resampling ratio is detected, just suggest to the user that they useDecimateRecordinginstead. But, that would change existing behavior, and I don't think this is too terribly complicated as-is.