Repository navigation
fix: corrected threshold reset when returning to ongoing season. - #16
Merged
Merged
Conversation
Co-Authored-By: Claude <claude@users.noreply.github.com>
StarsExpress
changed the title
Co-Authored-By: Claude <claude@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-adjusted Thresholds
In the past, the season "change" handler only forced a reset for ongoing -> historical.
Reverse direction relied on generic clamp, which fell back to the default only while ongoing season's pool max stayed below the old value.
With 2026 Week 7 data the max (ED 256, DI 244, OL 304) now exceeds 230/300, old values fit and was kept.
Added
seasonSwitchChangesThresholdDefault()indata.js:true when two seasons carry different
default_thresholds.The handler uses it, so both ongoing <-> historical directions reset,
while two finalized seasons — same static default — keep the user's value.