Repository navigation
refactor: let NFL & NCAAF share same DB workflows. - #19
Merged
Merged
Conversation
• Teams references. • Database schemas. Co-Authored-By: Claude <claude@users.noreply.github.com>
Refactored `teams/` as well. Co-Authored-By: Claude <claude@users.noreply.github.com>
StarsExpress
changed the title
Co-Authored-By: Claude <claude@users.noreply.github.com>
StarsExpress
marked this pull request as ready for review
October 30, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural Preparations For NCAAF
Move engine and
SessionLocalintodatabase/session.py.Declare each category's columns once in
database/columns.py: required-column check, row building and API serializers all read it.Take the stat models' identity and metric columns from mixins.
Merge the two ingestion functions into one spec-driven ingest_category.
Share
percent_of()andwrite_position_sheets()across the two preprocessing scripts.Build three API endpoints from a
build_api_router()factory; NFL stays mounted at/api/metadata,/api/pass_rush,/api/pass_block.