Repository navigation
fix: loader freeze on manual plugin install/update - #977
Open
mubaraknumann wants to merge 1 commit into
Open
mubaraknumann wants to merge 1 commit into
mubaraknumann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/
Description
This fixes issue: N/A
I've been chasing an issue where, when I manually install my plugin via zip or URL, my plugin gets stuck on "Downloading any external binaries" or "Installing plugin". After that Decky stops responding, the settings page just stays dark, and restarting plugin_loader doesn't bring it back because the stuck loader process survives Steam restart and I need to do a system restart.
Fixes:
Changed
_read_single_line()to returnNonewhen a plugin's socket closes, and added a check in_response_listener()to stop listening once the plugin process has exited. Fixes the loader stuck looping on a dead connection.Added fork hooks in
plugin.pythat hold the logging locks while a plugin process is forked and reset its signal handlers. Avoids newly started plugin from hanging on its first log line or pass a stop signal back to the loader.Changed
_install()to look up the installed plugin by the name inplugin.json. ZIP should get installed after running copy is first uninstalled cleanly instead of unpacking over it.Testing
Tested on a Steam Deck on Prerelease with a dev build. I did 15 updates and zip installs in a row over a running plugin and none of them hung or left a broken install. Before the fix the same Deck hung twice in about ten tries.