Render BioBrawl 2026 results by division - #1
Merged
Conversation
From 2026 the competition runs separate High School and Middle School brackets
plus a mock round. results.winners has three flat slots (first/second/third),
which cannot represent that, so /results/2026 showed TBD.
- types.ts: add results.divisions[] as { name, places[{ rank, team, award }] }.
results.winners is kept and still documented, so the 2024 and 2025 pages are
unaffected.
- Podium.svelte: take a places array instead of three fixed props, so a division
with only a first and second renders without an empty third plinth. Ranks map
to the existing gold/silver/bronze styling and heights. The three-slot props
remain as a fallback, including the TBD placeholders for an event with no
results yet. Prize amounts render under the team name when present.
- results/[eventID]: render one titled podium per division, falling back to the
single podium when divisions is absent.
The winner names are content, not code — this branch renders them but does not
supply them. biobrawl-2026/ holds the Sanity mutation plus the open questions
that need answering before it is applied: the unlabelled award block, the
Wayzata / Wayzata CMS naming difference, the stale 2025 results description,
and the Studio schema addition needed to make divisions editable.
Verified against the real /results/2026 with the winners stubbed in locally:
all three divisions render, and the 2025 three-place layout is unchanged.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ision-results # Conflicts: # .gitignore
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟡 Changes recommended
The updated Podium rendering has at least two correctness issues affecting award visibility and rank styling for places beyond third.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds division-aware results rendering for BioBrawl 2026 while keeping backward compatibility with legacy single-ladder winner fields, and updates the podium UI to support an arbitrary number of ranked places (plus optional prize amounts).
Changes:
- Render separate podiums per division when
eventData.results.divisionsis present, otherwise fall back to legacywinners. - Extend results types with
Division/Placeto represent per-division rankings and optional awards. - Update
Podiumto acceptplaces[], re-order visually for podium layout, and display optional award amounts.
File summaries
| File | Description |
|---|---|
| src/routes/results/[eventID]/+page.svelte | Renders division-specific podiums with a legacy fallback and adds division section styling. |
| src/lib/types.ts | Introduces Division and Place types and documents legacy vs division result shapes. |
| src/lib/components/Podium.svelte | Adds places API, dynamic rendering/reordering, and optional award display with new styling. |
| .gitignore | Normalizes ignored build/output directories and adds *.log. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Stringatlas
force-pushed
the
biobrawl-2026-division-results
branch
from
August 24, 2026 03:40
c49e096 to
e503308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biobrawlbaseTesting
npm run checknpm run build