Repository navigation
Prepare winget publishing for stable releases - #106
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The PR appears safe to merge, with no actionable issues found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
UninstallDisplayName=ControlFreak, so Apps & Features andwinget listshowControlFreakinstead ofControlFreak version <version>. The version stays in its own column. TheAppId, and so the wingetProductCodeControlFreak.Windows.x64_is1, is unchanged.release.ymlgets awingetjob that runs after a stable release is published. It downloads Komac 2.17.1, checks its SHA-256 like the existing Hawk and Inno Setup downloads, and runskomac update SubhransuDe.ControlFreak --submitto open the winget-pkgs PR.WINGET_TOKENsecret is passed only to the Komac step.CONTRIBUTING.mddescribes the job, the token it needs and how to retry it.CHANGELOG.mdrecords the display-name change.Komac is called directly instead of through
vedantmgoyal9/winget-releaser, which installscargo-bins/cargo-binstall@mainand an unpinned Komac internally. That would bypass the repository's SHA pinning.The job opens nothing until
SubhransuDe.ControlFreakexists in winget-pkgs. The first version (0.1.0) will be submitted by hand.Checks
make check(formatting, Clippy, tests, and release build)actionlint,typosandgitleakson the staged changes pass.winget install --custom "/CLIENTS=codex"configures Codex.winget uninstallremoves the app and keeps client entries, as documented.Not verified
wingetjob has not run, because that needs a stable release, the secret and an existing winget package.docs/install.mdalready mentions.Generated with claude-opus-5-5