Skip to content

Fix GUI crash when opening a file before the media player is ready #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlySerry0 wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −0
Open

Fix GUI crash when opening a file before the media player is ready #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e135057
Guard against crash when opening a file before the media player is ready
AlySerry0 Aug 12, 2026
b1faef9
Merge branch 'master' into fix/gui-crash-on-null-player
AlySerry0 Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions syncplay/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,10 @@ def openFile(self, filePath, resetPosition=False, fromUser=False):
self.playlist.loadPlaylistFromFile(filePath, resetPosition)
return

if self.playerIsNotReady():
self.ui.showErrorMessage(getMessage("player-not-ready-error"))
return

self.playlist.openedFile()
self._player.openFile(filePath, resetPosition)
if resetPosition:
Expand Down
1 change: 1 addition & 0 deletions syncplay/messages_en.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@
"mpv-failed-advice": "The reason mpv cannot start may be due to the use of unsupported command line arguments or an unsupported version of mpv.",
"player-file-open-error": "Player failed opening file",
"player-path-error": "Player path is not set properly. Supported players are: mpv, mpv.net, VLC, MPC-HC, MPC-BE, mplayer2, and IINA",
"player-not-ready-error": "Media player is not ready yet. Please wait for it to finish starting up and try again.",
"hostname-empty-error": "Hostname can't be empty",
"empty-error": "{} can't be empty", # Configuration
"media-player-error": "Media player error: \"{}\"", # Error line
Expand Down
6 changes: 6 additions & 0 deletions syncplay/ui/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,9 @@ def getInitialMediaDirectory(self, includeUserSpecifiedDirectories=True):

@needsClient
def browseMediapath(self):
if self._syncplayClient.playerIsNotReady():
self.showErrorMessage(getMessage("player-not-ready-error"))
return
if self._syncplayClient._player.customOpenDialog == True:
self._syncplayClient._player.openCustomOpenDialog()
return
Expand Down Expand Up @@ -1280,6 +1283,9 @@ def browseMediapath(self):

@needsClient
def OpenAddFilesToPlaylistDialog(self):
if self._syncplayClient.playerIsNotReady():
self.showErrorMessage(getMessage("player-not-ready-error"))
return
if self._syncplayClient._player.customOpenDialog == True:
self._syncplayClient._player.openCustomOpenDialog()
return
Expand Down