Skip to content

Let users switch duration fields between seconds, minutes, and hours - #45

Merged
nihey merged 1 commit into
mainfrom
feat/duration-unit-switcher
Sep 16, 2026
Merged

nihey merged 1 commit into
mainfrom
feat/duration-unit-switcher

Conversation

@nihey

@nihey nihey commented Sep 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Period, grace, and interval now open in the coarsest whole unit (for example 5 min instead of 300 seconds) with an s/min/hr toggle beside the number.
  • Switching units converts the stored duration; timeout stays seconds-only because its range is 1–60s. Create and edit both use the shared control.

Validation

  • Added or updated tests for behavior changes
  • Ran relevant tests and checks
  • Updated relevant documentation
  • Confirmed no production data, credentials, or populated .env files are included

Checklist

  • Conventional commit subject used
  • Scope is focused and ready for review

Test plan

  • New heartbeat check: Period shows 5 min; type 10; switch to seconds and confirm 600
  • Switch Period to hours, then back to minutes, without the duration jumping
  • HTTP Interval uses minutes; Timeout stays in seconds with no unit toggle
  • Edit an existing heartbeat and change Grace in minutes

Period, grace, and interval were stuck in raw seconds; the shared control now opens in the coarsest whole unit and converts when s/min/hr changes.
@nihey
nihey merged commit 1e44970 into main Sep 16, 2026
14 of 16 checks passed
@nihey
nihey deleted the feat/duration-unit-switcher branch September 16, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant