Repository navigation
Lint ruff : rétablir un CI vert (app/ et tests/) - #3
Merged
Merged
Conversation
Le job « lint (ruff) » du CI était rouge de longue date sur main : 66 violations préexistantes dans app/ et tests/ (les tests, eux, passaient). Corrigées ici pour rétablir un CI vert. - Imports et variables inutiles retirés (F401, F841, F811, F541). - Instructions multiples sur une ligne éclatées (E701, E702). - Imports de routers volontairement après setup_logging marqués # noqa: E402, suivant la convention déjà en place dans app/main.py. - Variables au nom ambigu « l » renommées (E741). Aucun changement de comportement : reformatage et suppression de code mort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objet
Le job
lint (ruff)du CI était rouge de longue date sur main : 66 violations préexistantes dansapp/ettests/. Les tests passaient, mais le check lint bloquait toute PR au vert. Cette PR rétablit un CI entièrement vert.Nature des corrections (sans changement de comportement)
setup_logging()marqués# noqa: E402, suivant la convention déjà présente dansapp/main.py.lrenommées (E741).Vérification
ruff check app/ tests/(version CI 0.9.3) : All checks passed. Tous les fichiers touchés compilent.Ordre de merge suggéré
Merger cette PR en premier ; les PR #1 (amorçage) et #2 (sauvegarde) repasseront alors au vert au ré-exécution de leurs checks.