fix(scaffold): emit .gitattributes and default npm scope to @tmhs#92
Merged
Conversation
Two defects hit and worked around during the godot-correctness-mcp birth, now
fixed at the source so no future born repo repeats them:
- Add templates/gitattributes.j2 and emit it for every born repo (both types,
alongside .gitignore): normalizes LF for ts/js/json/md/yml/yaml and marks
.gz/.wasm artifacts binary. Prevents CRLF phantom diffs on .json and mangled
committed binary artifacts.
- Default npm scope corrected from @{{ repo_owner | lower }} (-> @TMHSDigital)
to @TMHS in package.json.j2 and site.json.j2. The GitHub org references
(TMHSDigital in URLs) are unchanged and correct.
License already emits CC-BY-NC-ND-4.0 (package.json + LICENSE); verified, no
change. STANDARDS_VERSION unchanged (not a standards change); VERSION bumped
1.17.1 -> 1.17.2 per the meta-repo contract for a scaffold fix.
Signed-off-by: fOuttaMyPaint <154358121+TMHSDigital@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Signed-off-by: fOuttaMyPaint <154358121+TMHSDigital@users.noreply.github.com>
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two scaffold defects at the source
Both were hit and worked around locally during the
godot-correctness-mcpbirth; fixed here so no future born repo repeats them.Proven by live run (scratch generator run, no GitHub side effects)
Generated both a mcp-server and a cursor-plugin into throwaway dirs (deleted after) and asserted the emitted output:
.gitattributespresent with* text=auto,eol=lffor ts/js/json/md/yml/yaml, and*.gz/*.wasmmarked binary — in both repo types.@tmhs/<slug>inpackage.jsonand thesite.jsonnpx line; zero@tmhsdigitaloccurrences anywhere in either generated repo.CC-BY-NC-ND-4.0in bothpackage.json("license") andLICENSE(SPDX-License-Identifier).Established by inspection
package.json.j2:2andsite.json.j2:15(@{{ repo_owner | lower }}→@tmhsdigital); corrected to@tmhs. All remainingTMHSDigitalreferences are GitHub-org URLs (repository/homepage/bugs, drift-check/pages/release action refs) and are left unchanged.cc-by-nc-nd-4.0is the only license option;LICENSE.j2emits the full CC-BY-NC-ND-4.0 text). No license change was needed.Placement note (superset of the ask)
.gitattributesis emitted from the generator's shared/unconditional file loop (next to.gitignore), so both repo types get it — fixing the CRLF phantom-diff root cause universally rather than mcp-server-only. Harmless for cursor-plugins (they simply have no.gz/.wasm).STANDARDS_VERSION unchanged (not a standards change). VERSION bumped 1.17.1 → 1.17.2 per the meta-repo contract for a scaffold fix.