Skip to content

fix(tradingagents): clarify reports and remove unused budgets - #171

Merged
TNT-Likely merged 2 commits into
mainfrom
fix/report-notification-details
Oct 3, 2026
Merged

TNT-Likely merged 2 commits into
mainfrom
fix/report-notification-details

Conversation

@TNT-Likely

Copy link
Copy Markdown
Owner

Background

Agent notifications did not identify the stock being analyzed. Deep-analysis reports omitted their saved date and displayed dollar amounts derived from assumed token counts and fixed model prices; the monthly budget inherited those inaccurate amounts. The README introduction also lacked alignment with its Trending badge, and screenshots appeared after the setup instructions.

Changes

  • Notifications: include the stock name and symbol in single-stock Agent titles across the inbox, preview, toast, and report dialog. Persist identity for new notices and recover it for legacy notices without changing read or archive state.
  • Reports: show the saved report date, generated timestamp, and actual provider-reported input/output/total Tokens. Mark incomplete usage explicitly, retain the latest cumulative usage beyond the 500-entry progress history limit, and remove heuristic dollar amounts from report UI, share cards, and newly generated report footers. Cached reports no longer claim to have been generated today.
  • Budget removal: remove the monthly budget panel, configuration controls, API query/endpoint, estimates, and execution checks. Accept and ignore legacy budget settings so model/debate/timeout configuration continues to work. Keep cooldown and trading-session guards.
  • UI and documentation: restore opener focus for controlled dialogs while respecting custom focus handoffs. Center the bilingual README introduction/navigation/badges, move the existing screenshot section before core features, and update the existing flow documentation for budget removal. Preserve Trending, demo, and screenshot assets.

Validation

  • .venv/bin/python -m pytest -q — 945 passed, 3 skipped; existing deprecation warnings.
  • .venv/bin/python -m pytest -q tests/test_tradingagents_usage.py tests/test_tradingagents_agent.py tests/test_notifications.py — 70 passed after final test organization and documentation cleanup.
  • pnpm --dir frontend exec vitest run — 203 passed across 51 files.
  • pnpm --dir frontend check:i18n, check:ui, check:market-colors, and build — passed. Local Node 24.19.0/pnpm 9.15.9; the repository pins Node 24.14.0. Existing engine/chunk-size warnings remain.
  • git diff --check and XML parsing of both flow diagrams — passed.
  • Chrome checks using temporary component fixtures: report, notification preview, and idle modal at 1440/390 px in light/dark themes (12 variants), including scroll, focus containment, Escape, opener focus, historical date, stock identity, partial usage, and absence of budget/fee labels.
  • GitHub Markdown API rendering plus browser layout checks for both READMEs at desktop/mobile widths in light/dark themes (8 variants); unchanged module contents, badge targets, local links, anchors, and folds verified.

Boundaries and risks

  • Historical reports without recorded usage display “not recorded”; missing provider usage is not treated as zero or estimated billing. Legacy raw cost fields and existing saved report bodies remain for compatibility.
  • The monthly budget endpoint is retired and legacy budget limits no longer block manual or automatic deep analysis.
  • Legacy notification stock names can be recovered only while a matching, unambiguous stock exists; newly published notices retain the name after stock deletion.
  • Browser validation used isolated component fixtures and GitHub-rendered Markdown with a local style wrapper, not an authenticated production end-to-end session. No paid analysis or real notification delivery was triggered for validation.

Follow-up

User acceptance of the report, notification, and README presentation before merging.

@TNT-Likely
TNT-Likely merged commit e0c9481 into main Oct 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant