Repository navigation
fix(tradingagents): clarify reports and remove unused budgets - #171
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Agent notifications did not identify the stock being analyzed. Deep-analysis reports omitted their saved date and displayed dollar amounts derived from assumed token counts and fixed model prices; the monthly budget inherited those inaccurate amounts. The README introduction also lacked alignment with its Trending badge, and screenshots appeared after the setup instructions.
Changes
Validation
.venv/bin/python -m pytest -q— 945 passed, 3 skipped; existing deprecation warnings..venv/bin/python -m pytest -q tests/test_tradingagents_usage.py tests/test_tradingagents_agent.py tests/test_notifications.py— 70 passed after final test organization and documentation cleanup.pnpm --dir frontend exec vitest run— 203 passed across 51 files.pnpm --dir frontend check:i18n,check:ui,check:market-colors, andbuild— passed. Local Node 24.19.0/pnpm 9.15.9; the repository pins Node 24.14.0. Existing engine/chunk-size warnings remain.git diff --checkand XML parsing of both flow diagrams — passed.Boundaries and risks
Follow-up
User acceptance of the report, notification, and README presentation before merging.