fix(activity): render feed rows as full sentences - #336
Merged
Conversation
Actor + verb + target concatenation cannot express German word order or conjugation, and member events name the actor in both slots. - one full-sentence resource per kind, _you/_other for conjugation - bold spans marked in the args so they survive formatting - self-join vs added-by-someone; left/removed drop the duplicate name - settlements get their own sentence instead of their default title - unknown names and relative timestamps localized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actor + verb + target concatenation cannot express German word order or conjugation, and member events name the actor in both slots.