Skip to content

feat(settings): link privacy policy - #340

Merged
DennisBauer merged 2 commits into
mainfrom
feat/privacy-policy-link
Aug 10, 2026
Merged

feat(settings): link privacy policy#340
DennisBauer merged 2 commits into
mainfrom
feat/privacy-policy-link

Conversation

@DennisBauer

@DennisBauer DennisBauer commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added privacy notices to account registration and guest sign-up flows, with localized German and English text.
    • Users can open the privacy policy directly from registration screens and profile settings.
    • Added a profile Privacy Policy entry with shield icon and browser-opening guidance.
  • Localization
    • Added German translations for all new privacy-related text.

Add a Privacy policy row above Open-source licenses in both the phone
and two-pane About sections, opening tabmates.de in the browser.

The URL is a constant rather than derived from BASE_URL_PUBLIC: that
host follows the environment switcher, while the policy must always
resolve to the production site.
Show a privacy notice under the submit button on the register and guest
sign-up screens, where account data is actually collected.

Informational text, no consent checkbox: sign-up data is processed to
perform the contract (GDPR Art. 6(1)(b)), so Art. 13 asks us to inform,
not to obtain consent.
@DennisBauer DennisBauer added the feature New feature or request label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b9cede9-b59f-4a81-8e07-086ec3de1984

📥 Commits

Reviewing files that changed from the base of the PR and between 461ac6b and cd40dd4.

📒 Files selected for processing (10)
  • core/domain/src/commonMain/kotlin/de/tabmates/core/domain/legal/LegalUrls.kt
  • features/authentication/presentation/src/commonMain/composeResources/values-de/string.xml
  • features/authentication/presentation/src/commonMain/composeResources/values/string.xml
  • features/authentication/presentation/src/commonMain/kotlin/de/tabmates/features/authentication/presentation/components/PrivacyNotice.kt
  • features/authentication/presentation/src/commonMain/kotlin/de/tabmates/features/authentication/presentation/register/RegisterScreen.kt
  • features/authentication/presentation/src/commonMain/kotlin/de/tabmates/features/authentication/presentation/registerguest/RegisterGuestScreen.kt
  • features/tabgroup/presentation/src/commonMain/composeResources/drawable/ic_shield.xml
  • features/tabgroup/presentation/src/commonMain/composeResources/values-de/string.xml
  • features/tabgroup/presentation/src/commonMain/composeResources/values/string.xml
  • features/tabgroup/presentation/src/commonMain/kotlin/de/tabmates/features/tabgroup/presentation/navigation/profile/ProfileScreen.kt

📝 Walkthrough

Walkthrough

The change adds a shared privacy-policy URL, localized authentication notices, and a profile privacy-policy row. Registration and guest-registration screens display the notice. Profile layouts open the policy in a browser.

Changes

Privacy policy access

Layer / File(s) Summary
Shared privacy policy URL
core/domain/.../legal/LegalUrls.kt
Adds the public LegalUrls.PRIVACY_POLICY constant for the production policy URL.
Authentication privacy notice
features/authentication/presentation/.../composeResources/values*.xml, features/authentication/presentation/.../components/PrivacyNotice.kt, features/authentication/presentation/.../register/*.kt, features/authentication/presentation/.../registerguest/*.kt
Adds localized notice text and renders a clickable PrivacyNotice below the registration actions.
Profile privacy-policy row
features/tabgroup/presentation/.../composeResources/drawable/ic_shield.xml, features/tabgroup/presentation/.../composeResources/values*.xml, features/tabgroup/presentation/.../profile/ProfileScreen.kt
Adds localized policy labels, a shield icon, and privacy-policy rows to both profile layouts. Clicking the row opens the shared URL.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: diasdominik

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding privacy policy links across the application.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@DennisBauer
DennisBauer enabled auto-merge August 10, 2026 16:04
@DennisBauer
DennisBauer merged commit 6dc5400 into main Aug 10, 2026
4 checks passed
@DennisBauer
DennisBauer deleted the feat/privacy-policy-link branch August 10, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant