feat(settings): link privacy policy - #340
Merged
Merged
Conversation
Add a Privacy policy row above Open-source licenses in both the phone and two-pane About sections, opening tabmates.de in the browser. The URL is a constant rather than derived from BASE_URL_PUBLIC: that host follows the environment switcher, while the policy must always resolve to the production site.
Show a privacy notice under the submit button on the register and guest sign-up screens, where account data is actually collected. Informational text, no consent checkbox: sign-up data is processed to perform the contract (GDPR Art. 6(1)(b)), so Art. 13 asks us to inform, not to obtain consent.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe change adds a shared privacy-policy URL, localized authentication notices, and a profile privacy-policy row. Registration and guest-registration screens display the notice. Profile layouts open the policy in a browser. ChangesPrivacy policy access
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit