build: let contributors build with their own team#1750
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Point the app's Debug config at TablePro.Debug.entitlements, which omits the iCloud capability and uses a dynamic team prefix. Personal Apple teams can't provision iCloud, so the Debug build now signs with a free account and external contributors can build the app. Release still uses TablePro.entitlements with iCloud, and CI signs it explicitly. Finishes the contributor-build support started in #1028. Claude-Session: https://claude.ai/code/session_01Dtzk7mYAky4LPjp2HxYnMW
fbde0be to
1b72afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
External contributors can't build TablePro with their own Apple account (#1747). The Debug build uses
TablePro.entitlements, which includes the iCloud capability. Personal development teams can't provision iCloud, so the build fails with "Cannot create a Mac App Development provisioning profile for com.TablePro. Personal development teams do not support the iCloud capability."TablePro.Debug.entitlements(no iCloud, dynamic team prefix) was added for this in #1028 but was never wired into the project.Change
TablePro.Debug.entitlements. Release still usesTablePro.entitlementswith iCloud.docs/development/setup.mdx.Contributors still pick their own Team in Signing & Capabilities (already documented); this removes the one blocker a free account can't get past.
Why releases are unaffected
The Release config still points at
TablePro.entitlements, andbuild-release.shre-signs the app with--entitlements TablePro/TablePro.entitlements(iCloud) explicitly. CI passes the team on the command line.Tradeoff
Local Debug builds no longer carry iCloud, so iCloud sync won't run in Debug. Use a Release build to test that. This matches the #1028 intent.
Closes #1747
https://claude.ai/code/session_01Dtzk7mYAky4LPjp2HxYnMW