Repository navigation
Fix research recipe GitHub pack requirements and direct-tool validation - #5241
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research food trucks omit the
githubpack, hidingverify_review_receiptduring review verification. Declaregithubin both research recipes and extendundeclared-pack-requirementto catch direct tools missing from a recipe's food-truck catalog, while preserving existing skill-category validation.Regenerate compiled recipes, contract cards, and the research diagram hash; remove the four obsolete callability exemptions; update regression tests and authoring documentation. Empty-pack validation includes exploration tools to match the runtime's actual kitchen visibility. The warning-only validation fixture now declares
kitchen-corefor its headlesstest_checkcall.Validation:
pre-commit run --all-filespassed.test_check/task test-local-gatepassed: 18,931 passed, 420 skipped, 13 xfailed.Fixes #5178.
Plan deviations and audit dispositions:
The plan treats
KITCHEN_GATED_TOOLSas the complete empty-pack catalog, but the runtime branch enableskitchen, and exploration tool registration includes that tag. The original runtime test asserted inclusion ofKITCHEN_GATED_TOOLS; it did not exclude exploration. The strengthened runtime regression proves thatsubmit_exploration_queryis visible andpost_pr_reviewis hidden under empty packs. Existing recipe rule tests independently cover the corresponding validation outcomes. The union corrects validation without changing server visibility; broker authorization remains separate.