Repository navigation
test: add credential-free clean-install E2E coverage - #5246
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a credential-free
clean-installE2E test in a fresh user container. The harness runs install, initializes a scratch Git repository with the gitleaks hook, and validates the complete doctor JSON report. Unexpected diagnostics, failed commands, malformed reports, and stale expectations fail the gate.The catalog and CI matrix carry the new test kind. Its Docker route forwards no provider or sandbox credentials and mounts no home directories; command evidence and credential-free redaction remain available after failures. Known defects are recorded as
expected_failurerather than a clean pass, matching only exact diagnostics linked to open bugs #5242, #5243, and #5244.Closes #5231.
Validation
pre-commit run --all-filespassed with changes staged.test_check/task test-local-gatepassed: 15,702 passed, 207 skipped, 12 xfailed.usertarget and ran the committed harness in a fresh container with only scripts/output mounts: exit zero,outcome: expected_failure, four exact linked findings, no unexpected findings. Credential-free redaction passed.