Repository navigation
Fix plan-part contract binding, replan feedback, and E2E evidence - #5262
Merged
Merged
Conversation
This was referenced Oct 11, 2026
Trecek
added a commit
that referenced
this pull request
Oct 13, 2026
) Model-written plans could fail the sealed plan-set gate because the planning templates did not show the required allocation grammar. Rejected binds could then return empty feedback, causing a replan to repeat the same mistake. Failed E2E runs also discarded the plans and orchestrator transcripts needed to diagnose the rejection. This change: - Makes the make-plan and rectify templates conform to the actual verifier, tests their worked examples, and tells dry-walkthrough to preserve the form. - Returns actionable feedback for every defective part and rejects coverage-failure results with blank feedback, including empty-allocation cases. - Makes recipes use the producer's captured part list, documents terminal failure dispositions, and guards the existing bounded replan routes. Regenerates compiled recipes and derived hashes, and updates measured delivery baselines without changing budget limits. - Retains pipeline plans and Claude transcripts for unsuccessful E2E runs, skips symlinks, records collection errors without changing the verdict, and carries the evidence through existing redaction and upload steps. Validation: each phase independently passed the configured test_check gate and pre-commit run --all-files. The final gate reported 50,558 passed, 609 skipped, and 29 xfailed. All three recipes validate successfully with no new semantic findings; existing advisory findings remain. Related to #5259. The README documents the real-model bind check required after merge and before CI commissioning; that operator check has not been run. The original discarded MiniMax plans remain unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model-written plans could fail the sealed plan-set gate because the planning templates did not show the required allocation grammar. Rejected binds could then return empty feedback, causing a replan to repeat the same mistake. Failed E2E runs also discarded the plans and orchestrator transcripts needed to diagnose the rejection.
This change:
Validation: each phase independently passed the configured test_check gate and pre-commit run --all-files. The final gate reported 50,558 passed, 609 skipped, and 29 xfailed. All three recipes validate successfully with no new semantic findings; existing advisory findings remain.
Closes #5259. The README documents the real-model bind check required after merge and before CI commissioning; that operator check has not been run. The original discarded MiniMax plans remain unavailable.