Repository navigation
feat: add dated, interpreted run analyses - #5265
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dated, self-contained run analyses from a frozen report-index snapshot. The
analyze-runskill prepares measurements, writes evidence-linked interpretation, and publishes findings beside the existing deck charts. Unchanged inputs reuse the first verified completed interpretation; previous analyses remain intact.Validation
pre-commit run --all-filespassed.test_checkrunning the configuredtask test-local-gatepassed onc328ff19f: 51,305 passed, 617 skipped, 29 xfailed.task test-checkpassed onc328ff19f: exit 0,TEST_RESULT=PASS, 54,714 passed, 810 skipped, 29 xfailed.Implementation locations
The analysis implementation lives in
report/_analysis.pyto preserve the deck package's file limit. The publicvalidate_rollout_markerfunction is restored to the planned_type_results.pylocation, which measures 747 budgeted lines. Its shared private timestamp and scope helpers remain besideRolloutMarkerin_type_results_records.py; putting the parser back too would require 762 lines against the 750-line cap. The planned public report/deck and core APIs are retained.Audit findings addressed
The audit cited the earlier six-failure run. Those failures were fixed in
b43179335; fresh verification ofc328ff19fnow confirms both required commands pass. This update restores the public validator's planned definition location.The original “780 lines” justification omitted the measured source state. The earlier reduced file measured 714; reproducibly restoring all validation functions to that immutable state measures 780, and restoring validator plus parser measures 762. The final results module measures 747. The corrected evidence identifies commits and source hashes, and the public validator is now in its planned module.
The remaining analysis-module relocation preserves the deck's enforced 12-file limit and its public API. The
write-recipeinventory update is required by the bundled-skill filesystem contract. Publication/retention tests remain in the report layer, with separate CLI integration coverage, avoiding repeated CLI setup for domain-level concurrency and corruption cases.Closes #4654