Skip to content

fix: deliver checkpoint continuations from registry success routes - #5287

Merged
Trecek merged 8 commits into
developfrom
impl-checkpoint-delivery-authority-20261017-160806
Oct 17, 2026
Merged

Trecek merged 8 commits into
developfrom
impl-checkpoint-delivery-authority-20261017-160806

Conversation

@Trecek

@Trecek Trecek commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

Successful checkpoint responses could omit downstream recipe steps when routing through a fallback, including check_changes → test. Derive success reachability from registry outcome metadata and ordered result arms, and expand manual pull closures to whole segments so they deliver the same unit as inline bodies.

Adds wrapped-condition and registry-substitution tests, compiled-recipe invariants, production carrier and manual-pull regressions for implementation/remediation, and delivery-authority checks. Documents conservative delivery semantics in ADR-0004.

Validation:

  • All-files pre-commit passed.
  • Configured task test-local-gate: 31,650 passed, 3 failed, with 598 skipped and 15 xfailed.
  • Production sweep: 198 valid ingredient configurations, 54 distinct projections, 8,620 success-delivery obligations with none missing, and no carrier admission errors. Maximum carrier size: 9,708 bytes against the 10,000-byte limit.

This PR is a draft because validation remains failing:

  • The existing TestMergeWorktree::test_merge_worktree_merges_on_green[implementation] hits recipe_segment_post_effect_delivery_failure. Implementation stopped at the verified plan's explicit budget stop condition; the bound and closure rule are preserved.
  • The new closure-completeness invariant fails for both recipes because its literal-name assertion rejects a legitimate finalized step named done.

Refs #5286. The mixed I4 entry-hint observation was added to #4482's issue body. Full commissioning remains due after integration, with the review and strict-cleanup gates intact.

@Trecek
Trecek marked this pull request as ready for review October 17, 2026 22:14
@Trecek
Trecek added this pull request to the merge queue Oct 17, 2026
Merged via the queue into develop with commit 7824c51 Oct 17, 2026
11 checks passed
@Trecek
Trecek deleted the impl-checkpoint-delivery-authority-20261017-160806 branch October 17, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant