Repository navigation
fix: deliver checkpoint continuations from registry success routes - #5287
Merged
Trecek merged 8 commits intoOct 17, 2026
Merged
Conversation
Trecek
marked this pull request as ready for review
October 17, 2026 22:14
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful checkpoint responses could omit downstream recipe steps when routing through a fallback, including
check_changes→test. Derive success reachability from registry outcome metadata and ordered result arms, and expand manual pull closures to whole segments so they deliver the same unit as inline bodies.Adds wrapped-condition and registry-substitution tests, compiled-recipe invariants, production carrier and manual-pull regressions for implementation/remediation, and delivery-authority checks. Documents conservative delivery semantics in ADR-0004.
Validation:
task test-local-gate: 31,650 passed, 3 failed, with 598 skipped and 15 xfailed.This PR is a draft because validation remains failing:
TestMergeWorktree::test_merge_worktree_merges_on_green[implementation]hitsrecipe_segment_post_effect_delivery_failure. Implementation stopped at the verified plan's explicit budget stop condition; the bound and closure rule are preserved.done.Refs #5286. The mixed I4 entry-hint observation was added to #4482's issue body. Full commissioning remains due after integration, with the review and strict-cleanup gates intact.