Repository navigation
Fix delegated write evidence for owned child sessions - #5288
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful write-required run could be demoted to
zero_writeswhen its only edit came from an owned child. Admit successful owned-child writes only when they match an invocation-bound target whose content changed, while preserving separate root write counts.Declare
dry-walkthrough'splan_pathas its delegated target, bind it from canonical recipe or standalone inputs, and preserve the digest baseline across resume. Thread one evidence scope through normal and recovery paths, and reportdelegated_write_countonly insummary.json. Unowned, denied, unbound, unchanged, and out-of-scope writes remain insufficient; worktree temp-only exclusions remain enforced.Fixes #5285. After merge, integrate this fix into #5255 before fresh commissioning.
Validation:
pre-commit run --all-filespassed.task test-local-gate: 47,860 passed, 614 skipped, 29 xfailed.zero_writesand logsdelegated_writes_not_admitted.