Repository navigation
chore: bump pinned Node to 24.22.1 - #1914
robcresswell wants to merge 1 commit into
Conversation
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update Node.js version pin and prerequisite .nvmrc, CONTRIBUTING.md |
The .nvmrc version and documented minimum Node version change to 24.22.1. The .nvmrc reference and Node 22 warning remain unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Other
Possibly related PRs
- TanStack/ai#1890: Changes maintainer commands to direct
nodeexecution, which depends on the contributor Node.js runtime.
Suggested reviewers: alemtuzlak, lachlancollins
Merge Risk: 
Minimal · up to 4f7b3
-
The version update is limited to development and CI prerequisites and is ready to merge.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "chore: bump pinned Node to 24.22.1" matches the main change. The PR updates the Node pin in .nvmrc from 24.8.0 to 24.22.1 and the Node prerequisite in CONTRIBUTING.md. The title is specific, concise, and uses the conventional commit prefix.
Full details: Description check
-
Explanation
The description follows the repository template. It explains the change and the reason for it: the Node pin moves to the latest Node LTS, and CI reads .nvmrc through actions/setup-node. The Changes section lists both files. The checklist and Release Impact sections are filled in. The description adds a Risk / rollback section, which the template does not require. One checklist item is marked complete even though the PR objectives say the author did not confirm that pnpm run test:pr was run. The checklist also marks the docs and changeset items as complete while the description says no docs or changeset are needed. These are minor inconsistencies, and the core required information is present.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Smol change, just seemed sensible to align with latest node lts. I have some more work related to #1676, but wanted to start with something small. This is mostly just to avoid people needing to use older versions of node when developing in this repo (security, etc.) |
Bump the Node pin in
.nvmrcfrom 24.8.0 to 24.22.1, the latest Node LTS release. CI reads this file throughactions/setup-node, so CI also moves to 24.22.1.🎯 Changes
.nvmrc: 24.8.0 → 24.22.1.CONTRIBUTING.md: update the Node prerequisite to 24.22.1.No docs change: the library API did not change. No changeset: no published package changed.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.docs/for this change, or this change is not user-facing.pnpm changeset), or this PR does not change a published package.🚀 Release Impact
Risk / rollback
Low. This is a patch bump inside the Node 24 LTS line. If CI breaks, revert this PR.
Summary by CodeRabbit