Skip to content

chore: bump pinned Node to 24.22.1 - #1914

Open
robcresswell wants to merge 1 commit into
TanStack:mainfrom
robcresswell:chore/node-24-22
Open

robcresswell wants to merge 1 commit into
TanStack:mainfrom
robcresswell:chore/node-24-22

Conversation

@robcresswell

@robcresswell robcresswell commented Oct 26, 2026 •

Copy link
Copy Markdown

Bump the Node pin in .nvmrc from 24.8.0 to 24.22.1, the latest Node LTS release. CI reads this file through actions/setup-node, so CI also moves to 24.22.1.

🎯 Changes

  • .nvmrc: 24.8.0 → 24.22.1.
  • CONTRIBUTING.md: update the Node prerequisite to 24.22.1.

No docs change: the library API did not change. No changeset: no published package changed.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.
  • Docs: I updated docs/ for this change, or this change is not user-facing.
  • Changeset: I added a changeset (pnpm changeset), or this PR does not change a published package.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Risk / rollback

Low. This is a patch bump inside the Node 24 LTS line. If CI breaks, revert this PR.

Summary by CodeRabbit

  • Documentation
    • Updated the documented minimum Node.js version to 24.22.1.
  • Chores
    • Updated the project’s configured Node.js version to 24.22.1.

@changeset-bot

changeset-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4f7b39d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: TanStack/ai
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 8731d75
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 54bde4e1-8d28-4798-9876-81f52bdf9679
Commits

Reviewing files that changed from the base of the PR and between 8731d75 and 4f7b39d.

Files selected for processing: 2
  • .nvmrc
  • CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The Node.js version changes from 24.8.0 to 24.22.1 in .nvmrc and the contributor setup documentation.

Changes: Node.js Version

Layer / File(s) Summary
Update Node.js version pin and prerequisite
.nvmrc, CONTRIBUTING.md
The .nvmrc version and documented minimum Node version change to 24.22.1. The .nvmrc reference and Node 22 warning remain unchanged.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

  • TanStack/ai#1890: Changes maintainer commands to direct node execution, which depends on the contributor Node.js runtime.

Suggested reviewers: alemtuzlak, lachlancollins

Merge Risk: Minimal · up to 4f7b3

The version update is limited to development and CI prerequisites and is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "chore: bump pinned Node to 24.22.1" matches the main change. The PR updates the Node pin in .nvmrc from 24.8.0 to 24.22.1 and the Node prerequisite in CONTRIBUTING.md. The title is specific…
Description check Passed The description follows the repository template. It explains the change and the reason for it: the Node pin moves to the latest Node LTS, and CI reads .nvmrc through actions/setup-node. The Changes se…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore: bump pinned Node to 24.22.1" matches the main change. The PR updates the Node pin in .nvmrc from 24.8.0 to 24.22.1 and the Node prerequisite in CONTRIBUTING.md. The title is specific, concise, and uses the conventional commit prefix.

Full details: Description check

Explanation

The description follows the repository template. It explains the change and the reason for it: the Node pin moves to the latest Node LTS, and CI reads .nvmrc through actions/setup-node. The Changes section lists both files. The checklist and Release Impact sections are filled in. The description adds a Risk / rollback section, which the template does not require. One checklist item is marked complete even though the PR objectives say the author did not confirm that pnpm run test:pr was run. The checklist also marks the docs and changeset items as complete while the description says no docs or changeset are needed. These are minor inconsistencies, and the core required information is present.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robcresswell

robcresswell commented Oct 26, 2026 •

Copy link
Copy Markdown
Author

Smol change, just seemed sensible to align with latest node lts. I have some more work related to #1676, but wanted to start with something small. This is mostly just to avoid people needing to use older versions of node when developing in this repo (security, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant