[ryansolid]

🎯 Changes

The Solid packages here declare an open-ended solid-js peer (>=1.x). Solid 2.0.0 is due shortly. Once it's tagged latest, that range will accept it, so npm install will pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removes solid-js/store, createComputed, mergeProps/splitProps, onMount, batch and more.

This PR changes each range from >=X to ^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way @tanstack/solid-router 2.x and @tanstack/solid-query 6.x did it.

Prereleases (2.0.0-rc.*) never matched >=1.x, which is why nobody has run into this yet.

✅ Checklist

• Only peerDependencies ranges and a changeset change; no code changes.

Summary by CodeRabbit

• Chores
  • Restricted the supported SolidJS peer dependency range to compatible 1.x versions for the charts packages.

[changeset-bot]

🦋 Changeset detected

Latest commit: 6379521

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@tanstack/charts	Patch
@tanstack/solid-charts	Patch
@tanstack/alpine-charts	Patch
@tanstack/angular-charts	Patch
@tanstack/lit-charts	Patch
@tanstack/octane-charts	Patch
@tanstack/preact-charts	Patch
@tanstack/react-charts	Patch
@tanstack/react-native-charts	Patch
@tanstack/svelte-charts	Patch
@tanstack/vue-charts	Patch
@tanstack/charts-scales	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: ef969279-55e5-4a09-a7f4-acca5dcca0ef

Commits

Reviewing files that changed from the base of the PR and between 6379521 and 486ae51.

Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing: 1

• benchmarks/conformance/previews/manifest.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

Both chart packages change the solid-js peer dependency range from >=1.8 to ^1.8. A patch changeset records the updates for both packages. The conformance preview manifest’s sourceHash also changes.

Changes: SolidJS peer range

Layer / File(s)	Summary
Update peer dependency range packages/charts-core/package.json, packages/solid-charts/package.json, .changeset/solid-js-peer-cap.md, benchmarks/conformance/previews/manifest.json	Both package manifests change the solid-js peer dependency range to ^1.8. The changeset records patch releases for both packages. The conformance preview manifest has an updated sourceHash; its asset entries remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

• TanStack/charts#246: Adds a separate Solid 2 adapter entry while preserving the Solid 1 entry.

Suggested reviewers: greglum

Merge Risk: Minimal · up to 486ae

The scoped peer-range and manifest updates present no identified merge-blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: capping the Solid package peer dependency range for solid-js at ^1.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[tannerlinsley]

Thanks Ryan, this catches an important compatibility gap. The lockfile needs the matching change before this can land.

AI review notes:
At f9c6c65, packages/charts-core/package.json declares ^1.8, but its importer in pnpm-lock.yaml still records >=1.8.
An isolated metadata-only check using the exact root/core manifests and lockfile reproduced ERR_PNPM_OUTDATED_LOCKFILE, specifically naming that Solid specifier mismatch. This was not a full checkout test.
Update the core importer specifier to ^1.8, keeping the resolved version unchanged. The Solid adapter importer already uses its unchanged development dependency range, ^1.9.13.
Semver checks confirm the new peer range preserves stable Solid 1 versions from 1.8.0 and excludes stable Solid 2. Both required workflows are currently waiting for approval.

[ryansolid]

Thanks Tanner. Updated the lockfile specifier for solid-js in the charts-core importer to ^1.8; the resolved version is unchanged, and pnpm install --frozen-lockfile passes. The same lockfile fix went into form (TanStack/form#2456), pacer (TanStack/pacer#306) and devtools (TanStack/devtools#557).

[tannerlinsley]

Thanks Ryan, the lockfile correction checks out. The updated file matches the locally verified correction. This is now waiting on approval for the Conformance and Benchmarks workflows.

[tannerlinsley]

Thanks Ryan. I completed the full-checkout verification at 9e28cbd64ffc6635bb739a3849cab4f958b5eaa7: the frozen install passes across all 22 workspace projects with lifecycle scripts disabled, and the packed-package gate passes for bare React Native, Expo, all seven adapter checks and the unified core artifact.

The install left every tracked file unchanged. This adds independent full-workspace and package evidence to the earlier peer-range and lockfile checks. The two GitHub workflows still need approval, so this remains unmerged.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 9e28cbd

Command	Status	Duration	Result
nx run charts-workspace:ci-distributed	❌ Failed	5m 49s	View ↗
nx run charts-workspace:package-check	✅ Succeeded	2m 1s	View ↗
nx run charts-workspace:benchmark-check	✅ Succeeded	56s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-11-02 04:04:19 UTC

[nx-cloud]

Nx Cloud is proposing a fix for your failed CI:

We fixed both failing checks by formatting pnpm-lock.yaml with Prettier and refreshing the source hash in the catalog previews manifest.json. The hash covers the lockfile and packages/charts-core/package.json, both of which this PR changed. With the hash updated, format-check and catalog-preview-check should now pass.

Warning

• ❌ We could not verify this fix.
• The suggested diff is too large to display here, but you can view it on Nx Cloud ↗

  

Or Apply changes locally with:

npx nx-cloud apply-locally umUI-v9CL

Apply fix locally with your editor ↗   View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

[tannerlinsley]

Thanks Ryan. The formatting and preview conflict are fixed on this branch, and the updated checks are ready for workflow approval.

AI review notes:
The factory pushed 63795212 to format the lockfile and regenerate preview metadata, then merged current main as 486ae514. Parsed lockfile data was unchanged by formatting, and all 189 regenerated SVG previews matched the merged sources byte for byte.
Independent verification at 486ae514 passed the frozen workspace install with lifecycle scripts disabled, TypeScript, preview validation, and the full packed-package gate covering bare React Native, Expo, seven adapters and the unified artifact. These are local verification results. GitHub workflows 41416761819 and 41416761763 still require approval, so this remains unmerged.