chore(vitest): bump to v5 by harry-whorlow · Pull Request #2457 · TanStack/form

harry-whorlow · 2026-10-30T11:01:54Z

Summary by CodeRabbit

Chores
- Updated the project’s testing tools to newer versions, including the tools used for Angular package testing.
Tests
- Updated test setup to use the Vitest-compatible Testing Library matchers.

changeset-bot · 2026-10-30T11:02:02Z

⚠️ No Changeset found

Latest commit: 657cb90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-30T11:02:16Z

View your CI Pipeline Execution ↗ for commit 657cb90

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 48s	View ↗
`nx run-many --target=build --exclude=examples/**`	✅ Succeeded	36s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-30 11:06:42 UTC

socket-security · 2026-10-30T11:02:39Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Vulnerability	Quality	Maintenance
@vitest/coverage-istanbul@3.2.4 ⏵ 5.0.5			⁺¹²	⁺²
vitest@3.2.4 ⏵ 5.0.5	⁺¹	⁺⁷⁵	⁺¹	⁺¹
@analogjs/vite-plugin-angular@2.6.2 ⏵ 2.9.2
@analogjs/vitest-angular@2.6.2 ⏵ 2.9.2	⁺¹			⁺¹

View full report

github-actions · 2026-10-30T11:02:41Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-30T11:02:48Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: TanStack/form
Branch: vitest-upgrade
File: .coderabbit.yaml
Commit: 657cb90
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 915ad366-898b-47dc-83d3-55e5e68dd4f2

Commits

Reviewing files that changed from the base of the PR and between ed2f320 and 657cb90.

Files ignored due to path filters: 1

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing: 4

package.json
packages/angular-form/package.json
packages/lit-form/tests/group.test.ts
packages/lit-form/tests/simple.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The pull request updates Vitest and Analog Angular development dependency ranges. It also switches two Lit test setup imports to the Vitest-specific jest-dom entry point.

Changes: Test tooling updates

Layer / File(s)	Summary
Vitest dependencies and Lit test setup `package.json`, `packages/lit-form/tests/group.test.ts`, `packages/lit-form/tests/simple.test.ts`	Vitest and `@vitest/coverage-istanbul` now use version range `^5.0.5`. Both Lit tests import `@testing-library/jest-dom/vitest`.
Angular development dependencies `packages/angular-form/package.json`	`@analogjs/vite-plugin-angular` and `@analogjs/vitest-angular` now use version range `^2.9.2`.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: crutchcorn

Merge Risk: Minimal · up to 657cb

The dependency and test setup updates are compatible with the repository's declared CI runtime and are mergeable.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		No pull request description was provided. The required Changes, Checklist, and Release Impact sections are missing.	Add a description that follows the repository template. Describe the Vitest upgrade and its motivation, complete the checklist, and state whether the change is dev-only or requires a changeset.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the primary change: upgrading Vitest to version 5.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)

Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-30T11:03:53Z

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@2457

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@2457

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@2457

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@2457

@tanstack/preact-form

npm i https://pkg.pr.new/@tanstack/preact-form@2457

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@2457

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@2457

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@2457

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@2457

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@2457

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@2457

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@2457

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@2457

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@2457

commit: 657cb90

codecov-commenter · 2026-10-30T11:07:47Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (6892ed0) to head (657cb90).
⚠️ Report is 283 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
- Coverage   90.35%   89.82%   -0.53%     
==========================================
  Files          38       66      +28     
  Lines        1752     3235    +1483     
  Branches      444      811     +367     
==========================================
+ Hits         1583     2906    +1323     
- Misses        149      295     +146     
- Partials       20       34      +14

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chore(vitest): bump to v5

657cb90

LeCarbonator approved these changes Oct 30, 2026

View reviewed changes

harry-whorlow merged commit 314ea3b into main Oct 30, 2026
9 checks passed

harry-whorlow deleted the vitest-upgrade branch October 30, 2026 11:27

coderabbitai Bot mentioned this pull request Oct 30, 2026

chore(vitest): migrate to vitest browser mode for react #2458

Open

Navigation Menu

Repository navigation

chore(vitest): bump to v5 - #2457

chore(vitest): bump to v5#2457
harry-whorlow merged 1 commit into
mainfrom
vitest-upgrade

harry-whorlow commented Oct 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 30, 2026

Uh oh!

nx-cloud Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

socket-security Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 30, 2026

Uh oh!

codecov-commenter commented Oct 30, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

harry-whorlow commented Oct 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 30, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 30, 2026

Uh oh!

codecov-commenter commented Oct 30, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

harry-whorlow commented Oct 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 30, 2026 •

edited

Loading

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading