Require course certificate templates - #126
Merged
Merged
Conversation
Hosts can assign a certificate-builder template per course without making the builder a hard dependency. Award Blade certificates stay the fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Optional builder class-strings and EditRecord typing tripped level 4 analysis. Co-authored-by: Cursor <cursoragent@cursor.com>
LMS ships no Course policy; Laravel denies update and hid Create/Edit Certificate Template on Edit Course. Co-authored-by: Cursor <cursoragent@cursor.com>
Hosts can convert existing LMS award certificates into builder templates without waiting on pixel-perfect layouts. Co-authored-by: Cursor <cursoragent@cursor.com>
Award Blades become templates on upgrade, then award is dropped. Hosts run filament-lms:upgrade-awards and migrate. Co-authored-by: Cursor <cursoragent@cursor.com>
johnwesely
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep both the tenant-scoped unique course indexes from 4.x and the certificate template migrations from this branch. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6b12c0f. Configure here.
CSV import omitted certificate_template_id, and award remigration queried the dropped column and reused same-named templates from other token sets. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lms_courses.awardis dropped after every course is assigned a livingcertificate_template_id.php artisan filament-lms:upgrade-awards(--dry-run,--force,--award=,--dump=) converts award Blades to templates.filament-lms:migrate-awards-to-templatesis a hidden alias.php artisan migraterunsdrop_award_from_lms_courses_table: backfill, require the FK (restrictOnDelete), dropaward.UPGRADING.md.Test plan
php artisan filament-lms:upgrade-awards --dry-runphp artisan migrateawardis gone--forcerefreshes{Label} Certificatelayouts only and does not retarget custom templatesNote
High Risk
Breaking schema and certificate rendering path; migrate depends on installing filament-certificate-builder and successful backfill before
awardis dropped.Overview
Breaking change: course completion certificates no longer use per-course
awardBlade views orconfig('filament-lms.awards'). Courses now require acertificate_template_idtied to tapp/filament-certificate-builder, with newintegrations.certificate_builderconfig and UPGRADING.md for the migration path.Data & upgrade: migrations add
certificate_template_id, thendrop_award_from_lms_courses_tablerunsMigrateAwardsToCertificateTemplates(from legacy award Blades/config), enforces a non-null FK withrestrictOnDelete, and dropsaward.filament-lms:upgrade-awards(--dry-run,--force,--award=,--dump=) previews or runs the conversion; a hidden alias remains for the old command name.Runtime & admin:
CertificateControllerrenders the builder view with course/user token context and returns 404 when no template is assigned;CourseResource/ Edit Course use a required template select plus create/edit template actions. New courses, factories, and SCORM imports default to Default Certificate. Certificate download on the completed page uses thefilament-lms::certificates.downloadroute.Reviewed by Cursor Bugbot for commit 6b12c0f. Bugbot is set up for automated code reviews on this repo. Configure here.