Skip to content

fix: mobile image step overflow and tap-to-zoom lightbox - #129

Merged
johnwesely merged 2 commits into
4.xfrom
fix-mobile-image-step-overflow-CU-868m8b61r
Sep 23, 2026
Merged

johnwesely merged 2 commits into
4.xfrom
fix-mobile-image-step-overflow-CU-868m8b61r

Conversation

@johnwesely

Copy link
Copy Markdown
Contributor

Summary

  • Keep landscape image (and document preview) steps inside the card on mobile by wrapping them in step-material-container and capping width at min(100%, 60vh × 16/9).
  • Add a tap-to-zoom lightbox so the full-size image is readable on phones (scroll/pinch in the overlay).
  • Intended as v5.0.1 after merge: tag v5.0.1 on 4.x (CHANGELOG updates from the release workflow).

https://app.clickup.com/t/868m8b61r

Test plan

  • Open a landscape image step on a phone-width viewport and confirm it no longer overflows the card
  • Tap “Tap to zoom”, confirm the full-size image opens, Next is hidden, and Close / Escape / backdrop dismisses
  • On a real device, confirm drag pans and pinch zooms (desktop mobile preview may fake-follow the mouse)
  • After merge, create a GitHub release named v5.0.1 targeting 4.x

Made with Cursor

John Wesely and others added 2 commits September 23, 2026 11:12
Class on the img used a 16:9 max-width from viewport
height, so landscape images overflowed the card.

Co-authored-by: Cursor <cursoragent@cursor.com>
Constrained landscape images are unreadable on mobile.

Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 43df6cd. Configure here.

role="dialog"
aria-modal="true"
aria-label="Image preview"
@click.self="open = false"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backdrop click cannot close lightbox

Medium Severity

@click.self on .lms-image-lightbox never runs because .lms-image-lightbox__scroller is sized to 100% width and height and sits on top of the dialog, so taps hit the scroller instead of the lightbox. Close and Escape still work, but the advertised backdrop dismiss does not.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 43df6cd. Configure here.

@johnwesely
johnwesely merged commit 579f566 into 4.x Sep 23, 2026
16 checks passed
@johnwesely
johnwesely deleted the fix-mobile-image-step-overflow-CU-868m8b61r branch September 23, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant