fix: mobile image step overflow and tap-to-zoom lightbox - #129
Merged
Merged
Conversation
Class on the img used a 16:9 max-width from viewport height, so landscape images overflowed the card. Co-authored-by: Cursor <cursoragent@cursor.com>
Constrained landscape images are unreadable on mobile. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 43df6cd. Configure here.
| role="dialog" | ||
| aria-modal="true" | ||
| aria-label="Image preview" | ||
| @click.self="open = false" |
Contributor
There was a problem hiding this comment.
Backdrop click cannot close lightbox
Medium Severity
@click.self on .lms-image-lightbox never runs because .lms-image-lightbox__scroller is sized to 100% width and height and sits on top of the dialog, so taps hit the scroller instead of the lightbox. Close and Escape still work, but the advertised backdrop dismiss does not.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 43df6cd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
step-material-containerand capping width atmin(100%, 60vh × 16/9).v5.0.1on4.x(CHANGELOG updates from the release workflow).https://app.clickup.com/t/868m8b61r
Test plan
v5.0.1targeting4.xMade with Cursor