Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
홈 화면의 소개글(bio)이 마이페이지와 다르게 보이던 불일치 버그를 수정합니다.
📝 Changes
What
DashboardMapper.toMyInfoResponse()가bio를ClubMember.bio(레거시 필드)에서만 가져오던 것을,ClubMember.userProfile?.bio ?: clubMember.bio순으로 조회하도록 수정DashboardMapperTest에 멀티프로필 할당/미할당 두 케이스 모두bio값을 검증하도록 테스트 보강Why
UserMyPageMapper)는UserProfile.bio(멀티프로필 시스템)를 읽는 반면, 홈 화면(DashboardMapper)은ClubMember.bio(프로필 시스템 도입 전 레거시 필드)를 직접 읽고 있었습니다.name/profileImage는 이미UserInfoMapper가 "프로필 우선, 없으면 레거시 fallback" 패턴으로 올바르게 처리하는데,bio만 이 패턴을 안 타고 있었습니다.How
ClubMapper.resolveMemberBio(),PenaltyMapper에서 이미 쓰고 있던 것과 동일한 fallback 패턴(member.userProfile?.bio ?: member.bio)을DashboardMapper.toMyInfoResponse()에도 동일하게 적용📸 Screenshots / Logs
💡 Reviewer 참고사항
✅ Checklist