Repository navigation
Custom NPC Champion Support - #941
Draft
Syntax-Sculptor wants to merge 3 commits into
Draft
Syntax-Sculptor wants to merge 3 commits into
Syntax-Sculptor wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY THIS MATTERS 📌
It's not possible with the current modding API.
...
Overview
This PR implements custom champion support via the addition of a new XML file,
championcolors.xml. This will allow mods to create proper custom champions instead of relying on arbitrary Lua data to work around the limitations.ROADMAP
championcolors.xmlregistration.Isaac.GetChampionColorByNamechampioncolors.xmlexists (using ASM patches)championcolors.xml(by default, callingMakeChampionwith a value greater than 25 defaults to the rainbow champion effect).championcolors.xmlor none at all to allow for custom shaders.